This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
v1.0.6: 🐼monium #532
Merged
v1.0.6: 🐼monium #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sammyd
commented
Nov 11, 2020
sammyd
commented
- Fix completed icon height issue (@bladebunny)
- Fix issue with downloads being deleted when app restarted (@byaruhaf)
- Fix issue with inconsistent sort status on library (@VegetarianZombie)
- Hide download settings for users that cannot download (@Zoha131)
- Design enhancements (@byaruhaf & @VegetarianZombie)
In the future, if we want to add more SettingsOption then we need to change just a single file :]
Change the filter view per Luke's design
Change subscription filter fix to be specific per request
Disable sort controls when fetching data
This fixes Black bar after downloaded course's issue #513
Fixing swiftlint issue
This fixes Welcome: Illustration vertical alignment issue #518
SnapshotHelper.swift:251:7: Inclusive Language Violation: Declaration hasWhiteListedIdentifier contains the term "whitelist" which is not considered inclusive. (inclusive_language) SnapshotHelper.swift:252:9: Inclusive Language Violation: Declaration whiteListedIdentifiers contains the term "whitelist" which is not considered inclusive. (inclusive_language) Constants.swift:49:20: Operator Usage Whitespace Violation: Operators should be surrounded by a single whitespace when they are being used. (operator_usage_whitespace) JSONAPIRelationship.swift:35:30: Operator Usage Whitespace Violation: Operators should be surrounded by a single whitespace when they are being used. (operator_usage_whitespace) JSONAPIDocument.swift:36:30: Operator Usage Whitespace Violation: Operators should be surrounded by a single whitespace when they are being used. (operator_usage_whitespace) Parameters.swift:209:12: Operator Usage Whitespace Violation: Operators should be surrounded by a single whitespace when they are being used. (operator_usage_whitespace) DownloadService.swift:558:54: Unused Closure Parameter Violation: Unused parameter "path" in a closure should be replaced with _. (unused_closure_parameter)
Guardpost was not aware of user permission hence calling destroyDownloads() function. This would remove all downloaded video's This fixes the issue #506
Set the Color of the space to Color.backgroundColor
update SwiftLint workflow to match readme & Fix's Swiftlint warnings for version 0.41.0
Updating guardpost with the retrieved permissions
Add Spacer()'s to vertically centered Illustration
Hide download settings from the users who don't have download access
…mark Lock Tag icon height for time-being to prevent parent view rendering issue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.