translate docs/cdn-links #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takanorip
reviewed
Feb 1, 2019
content/docs/cdn-links.md
Outdated
|
|
||
| ```html | ||
| <script crossorigin src="https://unpkg.com/react@16/umd/react.development.js"></script> | ||
| <script crossorigin src="https://unpkg.com/react-dom@16/umd/react-dom.development.js"></script> | ||
| ``` | ||
|
|
||
| The versions above are only meant for development, and are not suitable for production. Minified and optimized production versions of React are available at: | ||
| 上記のバージョンは開発のためだけのものあり、本番環境には適していません。圧縮・最適化された本番バージョンの React は下記で利用できます。 |
There was a problem hiding this comment.
次のような訳が良いと思います。
下記のリンクから利用できます。
There was a problem hiding this comment.
ありがとうございます！
そうですね、その通りに修正します
takanorip
reviewed
Feb 1, 2019
content/docs/cdn-links.md
Outdated
|
|
||
| ```html | ||
| <script crossorigin src="..."></script> | ||
| ``` | ||
|
|
||
| We also recommend to verify that the CDN you are using sets the `Access-Control-Allow-Origin: *` HTTP header: | ||
| また、利用している CDN が `Access-Control-Allow-Origin: *` という HTTP ヘッダを設定していることを確認してください。 |
There was a problem hiding this comment.
「また、」は不要だと思います。
上の文章の訳にあわせて、次のような訳が良いと思います。
利用している CDN が Access-Control-Allow-Origin: * という HTTP ヘッダを設定していることを確認することもお勧めします。
|
修正しました |
potato4d
requested changes
Feb 1, 2019
Co-Authored-By: kik4 <[email protected]>
|
ありがとうございます |
potato4d
approved these changes
Feb 1, 2019
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of #4
レビューお願い致します 🙇