Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check C++ on CI #2662

Closed
Tracked by #2516
emilk opened this issue Jul 10, 2023 · 1 comment · Fixed by #2901
Closed
Tracked by #2516

Check C++ on CI #2662

emilk opened this issue Jul 10, 2023 · 1 comment · Fixed by #2901
Assignees
@Wumpf
Labels
🌊 C++ API C/C++ API specific 🧑‍💻 dev experience developer experience (excluding CI)

Comments

@emilk
Copy link
Member

emilk commented Jul 10, 2023 •
edited
Loading

Compile (and later run) the C++ example on the CI.

See rerun_cpp/build_and_run.sh
@emilk emilk added 🧑‍💻 dev experience developer experience (excluding CI) 🌊 C++ API C/C++ API specific labels Jul 10, 2023
@emilk emilk mentioned this issue Jul 10, 2023
Closed
11 tasks
@Wumpf
Copy link
Member

Wumpf commented Jul 24, 2023

consider adding format check as well in the same go since we had issues with that.

@Wumpf Wumpf mentioned this issue Aug 2, 2023
Merged
6 tasks
Wumpf added a commit that referenced this issue Aug 3, 2023
@Wumpf
CI for C++ (formatting check + running tests) (#2901)
8d5d6b7 
* Fixes  #2662

### What

* Runs clang-format to check for unformatted files
* Builds and runs the minimal example
* Builds and runs rerun_sdk tests

Docker image script was in a broken state, fixed it and updated the
image everywhere.

Do not under any circumstances review commit per commit 😉 (srsly the
history is messed up)

TODO:
* [x] check if overall ci goes green
* [x] break both ci jobs on purpose (already did compile failures, try
actual test failure instead
* [x] fix it again (duh ;))

Future todo:
* #2903
* todos from #2890
* cache C++ build results?


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2901) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2901)
- [Docs preview](https://rerun.io/preview/pr%3Aandreas%2Fcpp%2Fci/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aandreas%2Fcpp%2Fci/examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
🌊 C++ API C/C++ API specific 🧑‍💻 dev experience developer experience (excluding CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI for C++ (formatting check + running tests) rerun-io/rerun
2 participants
@emilk @Wumpf