CI for C++ (formatting check + running tests)

[Wumpf]

• Fixes Check C++ on CI #2662

What

• Runs clang-format to check for unformatted files
• Builds and runs the minimal example
• Builds and runs rerun_sdk tests

Docker image script was in a broken state, fixed it and updated the image everywhere.

Do not under any circumstances review commit per commit 😉 (srsly the history is messed up)

TODO:

• check if overall ci goes green
• break both ci jobs on purpose (already did compile failures, try actual test failure instead
• fix it again (duh ;))

Future todo:

• Build with warnings as errors on CI for C++ #2903
• todos from Extend C++ RecordingStream with global/thread_local/flush/save/connect APIs & introduce C++ SDK tests #2890
• cache C++ build results?

Checklist

• I have read and agree to Contributor Guide and the Code of Conduct
• I've included a screenshot or gif (if applicable)
• I have tested demo.rerun.io (if applicable)

• PR Build Summary
• Docs preview
• Examples preview

[teh-cmc]

why --release?

[Wumpf]

Good question/observation. Entirely because I stumbled over this line and figured maybe this is more cache friendly then

--release so we can inherit from some of the artifacts that maturin has just built before

https://github.com/rerun-io/rerun/blob/main/.github/workflows/reusable_build_and_test_wheels.yml#L269

but maybe this doesn't make sense?
Arguably the cmake script should be configurable and probably build rerun_c with debug/release depending on what rerun_cpp is built!

[teh-cmc]

In this instance this is running independently from other jobs so building re_types in release should just slow things down I think.

Arguably the cmake script should be configurable and probably build rerun_c with debug/release depending on what rerun_cpp is built!

Yeah that would be nice, though always building rerun_c in release isn't too bad in and of itself I think.

Update: oh wait, I see that rerun_c depends on re_types through re_sdk! In which case building in release above does make sense but... why does rerun_c depends on re_types to begin with? All it needs is like Data{Cell/Row} and RecordingStream. Maybe we should have an option an re_sdk to discard all of the archetype stuff.

[Wumpf]

huh, yeah we have some work there to do! Creating an issue on making rerun_c smaller.
I'll keep the cmake as is for the moment, shouldn't be too impactful anyways - imho the important thing is that it's not fixed to Debug instead (i.e. don't force users to go through a debug c library)

[fake-name]

Hello, sudo apt-get -y install 'cmake libarrow-dev' is not valid bash. I doesn't try to install the two packages cmake and libarrow-dev, it instead tries to install a single package named cmake libarrow-dev (yes, including the space), which does not exist.