Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build with warnings as errors on CI for C++ #2903

Closed
Tracked by #2919
Wumpf opened this issue Aug 3, 2023 · 0 comments · Fixed by #2957
Closed
Tracked by #2919

Build with warnings as errors on CI for C++ #2903

Wumpf opened this issue Aug 3, 2023 · 0 comments · Fixed by #2957
Assignees
@Wumpf
Labels
🌊 C++ API C/C++ API specific 🧑‍💻 dev experience developer experience (excluding CI)

Comments

@Wumpf
Copy link
Member

Wumpf commented Aug 3, 2023

Also, there's a bunch of warning settings not in place for rerun_cpp right now!
@Wumpf Wumpf added 🧑‍💻 dev experience developer experience (excluding CI) 🌊 C++ API C/C++ API specific labels Aug 3, 2023
@Wumpf Wumpf mentioned this issue Aug 3, 2023
Merged
6 tasks
@Wumpf Wumpf changed the title Build with warnigs as errors on CI for C++ Build with warnings as errors on CI for C++ Aug 3, 2023
Wumpf added a commit that referenced this issue Aug 3, 2023
@Wumpf
CI for C++ (formatting check + running tests) (#2901)
8d5d6b7 
* Fixes  #2662

### What

* Runs clang-format to check for unformatted files
* Builds and runs the minimal example
* Builds and runs rerun_sdk tests

Docker image script was in a broken state, fixed it and updated the
image everywhere.

Do not under any circumstances review commit per commit 😉 (srsly the
history is messed up)

TODO:
* [x] check if overall ci goes green
* [x] break both ci jobs on purpose (already did compile failures, try
actual test failure instead
* [x] fix it again (duh ;))

Future todo:
* #2903
* todos from #2890
* cache C++ build results?


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2901) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2901)
- [Docs preview](https://rerun.io/preview/pr%3Aandreas%2Fcpp%2Fci/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aandreas%2Fcpp%2Fci/examples)
@Wumpf Wumpf mentioned this issue Aug 7, 2023
Closed
33 tasks
@Wumpf Wumpf self-assigned this Aug 10, 2023
@Wumpf Wumpf mentioned this issue Aug 10, 2023
Merged
3 tasks
Wumpf added a commit that referenced this issue Aug 15, 2023
@Wumpf
C++ Warning fixes, werror on ci, C++17 compliance (#2957)
16635be 
### What

* Fixes #2903 
* Part of #2919
* currate warning list for gcc/clang
* enable warnings as errors on CI, for simplicity it's always active on
roundtrip tests
* enable standard set of warning settings on all C++ targets
* fix warnings in codegen'ed code and manually written code
* fix accidental C++20 (should have been caught in theory by warnings
but it didn't trigger for unknown reason)

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2957) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2957)
- [Docs
preview](https://rerun.io/preview/pr%3Aandreas%2Fcpp%2Fwarning-fixes-and-ci-werror/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aandreas%2Fcpp%2Fwarning-fixes-and-ci-werror/examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
🌊 C++ API C/C++ API specific 🧑‍💻 dev experience developer experience (excluding CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

C++ Warning fixes, werror on ci, C++17 compliance rerun-io/rerun
1 participant
@Wumpf