-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ Warning fixes, werror on ci, C++17 compliance #2957
Conversation
c251103
to
565f760
Compare
Try |
but left it in anyways |
Remaining warning happens to be fixed in #2959. Not duplicating it in here, waiting for that instead! |
### What As kindly supplied by a user on Discord. Didn't get to test them myself yet but makes lot of sense to me regardless. * Part of #2919 * requires additionally C++20 fixes from #2957 * currently every dependend binary has to know about arrow, should be fixed as part of #2873 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2959) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/2959) - [Docs preview](https://rerun.io/preview/pr%3Aandreas%2Fcpp%2Fwindows-fixes/docs) - [Examples preview](https://rerun.io/preview/pr%3Aandreas%2Fcpp%2Fwindows-fixes/examples)
312d517
to
9c1db7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always nice to run on as many warnings as possible, especially for unsafe languages
…as errors enabled
9c1db7b
to
b166661
Compare
What
Checklist