Extend delete invocation REST endpoint to support different termination modes #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slinkydeveloper
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
LGTM, please update the documentation at https://docs.restate.dev/services/invocation/#cancel-an-invocation
Will do via restatedev/documentation#233 |
tillrohrmann
force-pushed
the
issues/996
branch
2 times, most recently
from
a8475d0 to
6500bc7
Compare
This commit extends the JournalTable::get_journal method to also return the journal index for each journal entry.
This commit introduces a new TerminationFlavor::Cancel which will gracefully terminate an invocation. The way it works is that only leaf operations are being terminated with a CANCELED_INVOCATION_ERROR. Leaf operations are all completable journal entries except for calls and inboxed invocations. For pending calls in a journal, a cancellation will propagate the cancellation to these calls. This commit adds support for canceling inboxed, invoked, suspended and virtual invocations. This fixes restatedev#986 and restatedev#943.
This commit fixes an asymmetry in handling completions for virtual invocations.
This commit enriches the information that is sent from the cancel REST endpoint to the server. Concretely, it now passes the InvocationTermination struct which allows to set how an invocation gets terminated.
…on modes This commit extends the existing delete invocation REST endpoint to accept an additional query parameter mode which allows to select between cancel and kill. The default is cancel. This fixes restatedev#996.
tillrohrmann
force-pushed
the
issues/996
branch
from
6500bc7 to
a19a7c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #995.
This commit extends the existing delete invocation REST endpoint to accept an
additional query parameter mode which allows to select between cancel and kill.
The default is cancel.
This fixes #996.