ver 1.18.0 #5
Closed
ver 1.18.0 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
richm
commented
Mar 15, 2022
richm
commented
- add --local; add yamllint; add pytest reqs
- allow the use of the script with the hub command
- fix automated mode
- use shellcheck for CI for shell scripts
- address shellcheck issues in our shell scripts
- add support for tox with pylint, pyunit, flake8, black, shellcheck
- Initial commit for lsr-role2collection.py
- RHELPLAN-42910 - Collections - develop a script to convert roles format to collections format
- lsr_role2collection.py - Supporting README filenames other than README.md and README-extra.md.
- lsr_role2collection.py - Converting "linux-system-roles." with "NAMESPACE.COLLECTION_NAME." in playbook files in the collection converted playbooks directory.
- lsr_role2collection.py - Fixing the help for "--src-path SRC_PATH".
- ansible_role_parser.py - appending '\n' to footer.
- RHELPLAN-56489 - Collection - script - merge 2 python files into one
- Adding lsr_role2collection.py to README.md. Adding the default value of --dest-path option in lsr_role2collection.py.
- RHELPLAN-42929 - Collections - script - add CI testing for collection
- Adjusting lsr_role2collection.py to the CI integration test env.
- lsr_role2collection.py - trailing comments were not properly handled
- Adding test cases import ansible.module_utils.utils0 # noqa:E501 import ansible.module_utils.utils1 as local1 # noqa:E501 matching "(\bimport) (ansible.module_utils.)(\S+)(.)(\s+#.+|.)$" to test_lsr_role2collection.py.
- lsr_role2collection.py - converting the value of roletoinclude
- lsr_role2collection.py - the source role path does not have to end with the role name
- lsr_role2collection.py - Avoid adding a duplicate link to README.md
- RHELPLAN-59755 - Collection - script - not include symlinks in the collection converted format
- lsr_role2collection.py - Support include_vars in the test playbooks
- use github actions instead of travis
- RHELPLAN-59755 - Collection - script - not include symlinks in the collection converted format
- Collection release scripts, data, docs
- RHELPLAN-59755 - Collection - script - not include symlinks in the collection converted format
- Changing the default collection name from "system_roles" to "linux_system_roles".
- remove dependency on ansible, use only ruamel parser
- lsr_role2collections: Instead of hardcoded "linux-system-roles", use the src-owner value in FQRN.
- Fixing a regex pattern based on the review by @richm.
- RHELPLAN-63729 - collections - need README for collection for Automation Hub
- Add script for building docs, from RHEL
- lsr_role2collection: bug fixes found in the packaging
- lsr_role2collection: bug fixes found in the packaging
- lsr_role2collection: bug fixes found in the packaging
- lsr_role2collection: bug fixes found in the packaging
- lsr_role2collection: bug fixes found in the packaging
- lsr_role2collection: bug fixes found in the packaging
- lsr_role2collection: bug fixes found in the packaging
- Ansible-galaxy collection - ease the import errors by adding .ansible-lint and ignore-2.9.txt
- Replacing "a collection of roles" with "a set of roles" in lsr_role2collection/collection_readme.md
- collection testenv requires python six
- Add a script to transform galaxy.yml (Add a script to transform galaxy.yml linux-system-roles/auto-maintenance#46)
- Commenting out empty dependencies in galaxy.yml
- ability to run a command in each repo
- add checking for hub credentials
- update README
- Fixing the dependencies value type in galaxy.yml
- bug fix
- RHELPLAN-69930 - Fix description field in galaxy.yml
- Bug fix in lsr_role2collection.py
- Bug fix in lsr_role2collection.py
- changes for collection release 0.0.3
- md2html.sh - adding an option -l
- Adding a missing E503 to lsr_role2collection/.ansible-lint
- suppress ansible-lint issues
- md2html.sh - Make sure there is no CRLF
- lsr_role2collection.py - Drop links from the Supported/Private role list
- Adding check_rpmspec_collection.sh
- Fixing check_rpmspec_collection.sh
- Introducing --new-role
- Fixing issue 65 (Fixing issue 65 linux-system-roles/auto-maintenance#68)
- Dependencies in the collection packaging (Improve dependencies in the packaging linux-system-roles/auto-maintenance#69)
- For .md to .adoc conversion, substitute pandoc with kramdoc (For .md to .adoc conversion, substitute pandoc with kramdoc linux-system-roles/auto-maintenance#61)
- lsr_role2collection.py - adding an ability to convert "- ROLENAME" to (lsr_role2collection.py - adding an ability to convert "- ROLENAME" to "- FQCN" in the doc files such as README linux-system-roles/auto-maintenance#70)
- release collection 1.3.0
- fix linter issues
- initial version
- release 1.4.0
- lsr_role2collection.py - Adding encoding="utf-8" to open. (lsr_role2collection.py - Adding encoding="utf-8" to open. linux-system-roles/auto-maintenance#78)
- update ansible-lint based on recent fixes
- lsr_role2collection.py - drop python-six dependency (lsr_role2collection.py - dropping python-six dependency linux-system-roles/auto-maintenance#79)
- pandoc - use gfm instead of markdown
- release fedora.linux_system_roles 1.5.0
- release 1.6.0; add meta/runtime.yml to collection
- release 1.7.0
- release collection version 1.8.0
- release 1.8.1
- release 1.8.2
- release 1.8.3
- release 1.8.4
- release 1.8.5
- Drop support for Ansible 2.8 by bumping the Ansible version to 2.9 (Drop support for Ansible 2.8 by bumping the Ansible version to 2.9 linux-system-roles/auto-maintenance#89)
- exclude ee_linux_system_roles from local-repo-dev-sync.sh
- release 1.9.0
- release 1.9.1
- Add the playbook for configuring a squid caching proxy server (Add the playbook for configuring a squid caching proxy server linux-system-roles/auto-maintenance#95)
- combine collection release and update into release_collection.py
- report-modules-plugins.py - static analysis of Ansible plugins
- fix
- flake8
- fix handling of templates in defaults and vars files
- handle template parsing error cases
- fix formatting
- check if dir exists and is not a link
- release 1.9.2
- release_collection.py - adding an option "--rpm path/to/rpm" (release_collection.py - adding an option "--rpm path/to/rpm" linux-system-roles/auto-maintenance#99)
- release 1.10.0
- provide repo, docs, homepage, issues for galaxy_transform
- support for ansible 2.11 and other versions
- create ignore and ansible-lint files when using rpm
- release_collection.py - Add --skip-git option; Skip ansible-galaxy if it does not exist. (release_collection.py - Add --skip-git option; Skip ansible-galaxy if it does not exist. linux-system-roles/auto-maintenance#103)
- use sys.executable instead of 'python' for running scripts
- release_collection.py - Add --skip-check option.
- make release_collection.py work on el7
- look for role/collection deps; report errors
- better handling for filter, test plugin files
- report usage of plugins defined locally
- release 1.10.1
- add src_owner to pass through to lsr_role2collection
- update platforms, ansible versions
- release 1.11.0
- release 1.12.0
- add support for role filter_plugins
- Add initial automate-collections-updates.py (Add initial automate-collections-updates.py linux-system-roles/auto-maintenance#113)
- Catch warning when Automation Hub is not accessible (Catch warning when Automation Hub is not accessible linux-system-roles/auto-maintenance#116)
- make it more user friendly (make it more user friendly linux-system-roles/auto-maintenance#117)
- version 1.13.0 (version 1.13.0 linux-system-roles/auto-maintenance#118)
- update to version 1.14.0 (update to version 1.14.0 linux-system-roles/auto-maintenance#119)
- release 1.15.0 (release 1.15.0 linux-system-roles/auto-maintenance#120)
- version 1.15.1 (version 1.15.1 linux-system-roles/auto-maintenance#122)
- [WIP] Improve update_vendored_collections.py and prepare to run in container ([WIP] Improve update_vendored_collections.py and prepare to run in container linux-system-roles/auto-maintenance#121)
- Add GitHub action that opens PR on pushes to update-vendored-collections (Add GitHub action that opens PR on pushes to update-vendored-collections linux-system-roles/auto-maintenance#123)
- Fix auto creation of PRs (Fix auto creation of PRs linux-system-roles/auto-maintenance#124)
- Fix Rich's nickname, branch printing, add note about opening Fedora PR
- Remove trailing quotes
- consistenly use 2 spaces for indentation (consistenly use 2 spaces for indentation linux-system-roles/auto-maintenance#126)
- add support for --extra-script for custom conversions (add support for --extra-script for custom conversions linux-system-roles/auto-maintenance#128)
- add support for --check-fqcn (add support for --check-fqcn linux-system-roles/auto-maintenance#127)
- handle builtin functools collection name; fix bug in testing output (handle builtin functools collection name; fix bug in testing output linux-system-roles/auto-maintenance#129)
- version 1.15.2 - vpn_ipaddr; kdump.service (version 1.15.2 - vpn_ipaddr; kdump.service linux-system-roles/auto-maintenance#130)
- add bindeps; get rid of requirements.txt (add bindeps; get rid of requirements.txt linux-system-roles/auto-maintenance#131)
- version 1.16.0 (version 1.16.0 linux-system-roles/auto-maintenance#132)
- some minor improvements (some minor improvements linux-system-roles/auto-maintenance#133)
- version 1.17.0 (version 1.17.0 linux-system-roles/auto-maintenance#134)
- Fix ansible.posix version to match linuxsystemroles.spec (Fix ansible.posix version to match linuxsystemroles.spec linux-system-roles/auto-maintenance#136)
- version 1.18.0
add copy=tests/setup_module_utils.sh
Add a `--local` switch - this allows you to copy files from your local clone in order to e.g. test with `tox` locally. Add support for the yamllint files. Add support for additional pytest and pytest26 reqs.
add --local; add yamllint
Use the `hub` command to allow workflows that use your local git user with your local git credentials e.g. As a regular user, perform the usual clone repo as origin fork repo as myusername make a change locally push the change to my forked repo to a branch submit a pull request from my forked repo to origin This also makes the sync script both idempotent and able to run incrementally. That is, you can have the following workflow: make changes to template sync the changes to repo R branch B create a PR from branch B make more changes to template sync the changes to repo R branch B push changes to branch B This will update the existing PR with a new commit with the additional changes on branch B This PR also addresses a major limitation of the sync script - it does not add new files to git. add support for --preserve option so that you can use your local git clone of linux-system-roles without your local directories being removed
allow the use of the script with the hub command
My previous commit broke automated mode. This fixes automated mode and cleans up the code a bit. There are two new cmdline flags: `--workdir /path/to/dir` - instead of using the `$WORKDIR` env. var., pass it in with this flag. This will automatically set `PRESERVE=true` so as not to accidentally remove any directories under your workdir. `--use-hub` - previously it would use `hub` automatically if found in the `$PATH`. Now, you must explicitly set `--use-hub` in order to use `hub`.
fix automated mode
shellcheck is used check shell scripts for many common errors. shellcheck is built-in to Travis CI This commit enables Travis CI shellcheck for shell scripts
…tomated-mode add shellcheck to CI
add support for tox with pylint, pyunit, flake8, black, shellcheck
add support for tox with pylint, pyunit, flake8, black, shellcheck
gist.github.com_sivel/bca2fe56680c76f0eea647f5477dd46b
…at to collections format
[Conversion script]
usage: lsr_role2collection.py [-h] [--namespace NAMESPACE] [--collection COLLECTION]
[--dest-path DEST_PATH] [--src-path SRC_PATH] [--role ROLE]
[--replace-dot REPLACE_DOT] [--subrole-prefix SUBROLE_PREFIX]
optional arguments:
-h, --help show this help message and exit
--namespace NAMESPACE
Collection namespace; default to fedora
--collection COLLECTION
Collection name; default to system_roles
--dest-path DEST_PATH
Path to parent of collection where role should be migrated
--src-path SRC_PATH Path to linux-system-roles
--role ROLE Role to convert to collection
--replace-dot REPLACE_DOT
If sub-role name contains dots, replace them with the specified value;
default to '_'
--subrole-prefix SUBROLE_PREFIX
If sub-role name does not start with the specified value, change the name to
start with the value; default to an empty string
[Helper script]
lsr_roles2collections.sh
Adding a role to collection converter tool lsr_role2collection.py
…E.md and README-extra.md.
…PACE.COLLECTION_NAME." in playbook files in the collection converted playbooks directory.
Converting "linux-system-roles." with "NAMESPACE.COLLECTION_NAME." in
lsr_role2collection.py - Supporting README filenames other than README.md and README-extra.md.
--src-path SRC_PATH Path to the parent directory of the source role;
default to ${HOME}/linux-system-roles
lsr_role2collection.py - Fixing the help for "--src-path SRC_PATH".
Fixing yamllint new-line-at-end-of-file. error no new line character at the end of file (new-line-at-end-of-file)
ansible_role_parser.py - appending '\n' to footer.
- Merging ansible_role_parser.py into lsr_role2collection.py. - Putting the main part of lsr_role2collection.py into main() function and call it 'if __name__ == "__main__"'. - Adjusting unittests to the refactored functions.
RHELPLAN-56489 - Collection - script - merge 2 python files into one
Adding the default value of --dest-path option in lsr_role2collection.py.
Adding lsr_role2collection.py to README.md.
For the preparation of the task, adding an option to specify the
tests path to copy.
--tests-dest-path TESTS_DEST_PATH
Path to parent of tests directory in which rolename directory
is created and test scripts are copied to the directory;
default to DEST_PATH/NAMESPACE/COLLECTION
RHELPLAN-42929 - Collections - script - add CI testing for collection
- Renaming the main function to role2collection. - In the src path, allow a role is located in the directory other than "linux-system-roles". - Adding --src-owner to specify github owner, e.g., "linux-system-roles".
release 1.11.0
release 1.12.0
Add support for local filter_plugins
…er_plugins add support for role filter_plugins
* Add initial automate-collections-updates.py * Refactor the code Move var definitions, remove redundant list() and print() Break the code into functions Use centpkg clone rhel-system-roles instead of URL cloning Remove logic that checks changelogs * Fix black formatting issues Co-authored-by: Richard Megginson <[email protected]>
…es#116) * Catch warning when Automation Hub is not accessible * Rename for clarity * Rename script and dir to update_vendored_collections * Rename required.yml to vendored_collections.yml because required.yml gets renamed by `ansible-galaxy collection download`
…ntainer (linux-system-roles#121) * Add --anonymous for `centpkg clone` to clone over HTTPS * Remove repo directories before cloning to avoid conflicts * Remove target-os argument, add centpkg_cmd and fedpkg_cmd * Change move_tarballs_to_repo to copy_tarballs_to_repo * Fix replace_sources_in_spec to write the file after replace * Remove the branch argument, use centos_repo and fedora_repo * Remove upload_sources, not required for scratch build * Remove tarballs after script execution * Add work on fedpkg linux-system-roles repository * Add the delete_files function * Improve update_spec to add changelog entry and ready file properly * Push spec with new tarballs to Fedora * Configure git credentials, refractor, add comments * Add updating vendored_collections.yml * Add pushing to GitHub * Print different commit messages for Fedora and GitHub * Do not add remote if exists, checkout anyway if branch exists * Do not commit tarballs to GitHub, remove function that deletes files * Remove ansible.netcommon because rhel-system-roles do not vendore it
* Do not add remote for github, print pushing message * Fix action's destination_branch
This allows us to check for usage of plugins without FQCN. In collections, you must use FQCN for non-module plugins such as filters, tests, etc. that are not built-in. This applies to plugins that are defined by the role - Ansible will not automatically look them up in the collection if the role and the plugin are in the same collection. Now you can use --check-fqcn=plugins. Example: Found 9 errors ERROR: not FQCN: vpn_ipaddr at roles/vpn/tasks/mesh_conf.yml:14 The role in the collection should be using namespace.name.vpn_ipaddr
The vpn role needs bindep `openssl` and `dnf` We do not require `jmespath` or `netaddr` anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.