Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved diagnostics for AksIM2 encoder extending existing data structures #77

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Improved diagnostics for AksIM2 encoder extending existing data structures #77

merged 3 commits into from
Feb 22, 2023

Conversation

sgiraz
Copy link
Contributor

@sgiraz sgiraz commented Feb 16, 2023 •
edited
Loading

What's new:

  • the eoerror_valuestrings_HW list has been extended including possible error messages coming from the new AksIM2 encoder.
  • the eOerror_value_HW_t reflects the same changes

Notes:

  • These changes are required to be able to parse the error messages sent from the new FW.
  • Tested on 5-improved-joint setup (composed by EMS + AksIM2 + BLDC Motor)

cc @ale-git @pattacini

@sgiraz
Update eoerror_valuestrings_HW + eOerror_value_HW_t
0aea39b 
- include diagnostics messages for `aksim2`
@sgiraz sgiraz self-assigned this Feb 16, 2023
@marcoaccame marcoaccame mentioned this pull request Feb 20, 2023
Merged
@sgiraz sgiraz changed the title Update eoerror_valuestrings_HW + eOerror_value_HW_t Improved diagnostics for AksIM2 encoder extending existing data structures Feb 21, 2023
@pattacini pattacini mentioned this pull request Feb 21, 2023
Merged
marcoaccame
marcoaccame approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@marcoaccame marcoaccame merged commit 141b0ab into robotology:devel Feb 22, 2023
@sgiraz sgiraz deleted the feat/aksim2 branch February 22, 2023 09:59
@valegagge valegagge mentioned this pull request Mar 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoaccame marcoaccame marcoaccame approved these changes

@valegagge valegagge Awaiting requested review from valegagge

Assignees

@sgiraz sgiraz

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgiraz @marcoaccame