Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update required icub_firmware_shared_VERSION to 1.31.0 for AksIM2 encoder #856

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Update required icub_firmware_shared_VERSION to 1.31.0 for AksIM2 encoder #856

merged 1 commit into from
Feb 22, 2023

Conversation

sgiraz
Copy link
Contributor

@sgiraz sgiraz commented Feb 21, 2023 •
edited
Loading

What's new:

  • In order to see the new diagnostics messages generated by the AksIM2 encoder we have to use icub-firmware-shared v1.31.0 which contains the new (human-readable) diagnostics messages to visualize on the yarprobotinterface

Notes:

@pattacini
Copy link
Member

Depends on:

@sgiraz sgiraz mentioned this pull request Feb 21, 2023
Merged
pattacini
pattacini approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me 👍🏻

@sgiraz, remember to make the PR ready for review once you have merged the PR in icub-fw-shared.
Then, I'll wait for the CI to complete.

marcoaccame
marcoaccame approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me. i will merge the associated PRs on icub-firmware-shared and incub-firmware first.

@pattacini pattacini marked this pull request as ready for review February 22, 2023 08:34
@pattacini
Copy link
Member

PR made ready for review 👍🏻
CI commenced.

@pattacini pattacini merged commit 9a62dfd into robotology:devel Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoaccame marcoaccame marcoaccame approved these changes

@pattacini pattacini pattacini approved these changes

Assignees

@sgiraz sgiraz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sgiraz @pattacini @marcoaccame