Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

see if vcr can handle when requests written to disk #290

Closed
sckott opened this issue Dec 1, 2018 · 0 comments · Fixed by #345
Closed

see if vcr can handle when requests written to disk #290

sckott opened this issue Dec 1, 2018 · 0 comments · Fixed by #345
Milestone

Comments

@sckott
Copy link
Contributor

sckott commented Dec 1, 2018

open issue in vcr ropensci/vcr#81

@sckott sckott modified the milestones: v0.8, v0.9 Dec 1, 2018
@sckott sckott modified the milestones: v0.9, v1.0 Sep 20, 2019
@sckott sckott modified the milestones: v1.0, v0.9.6 Nov 30, 2019
sckott added a commit that referenced this issue Dec 30, 2019
sckott added a commit that referenced this issue Feb 18, 2020
sckott added a commit that referenced this issue Mar 23, 2020
* #290 - working on integrating vcr handling writing to disk, not done yet
related: ropensci/vcr#81 ropensci/webmockr#57

* playing with buoy tests, check back in #FIXME

* cpc_prcp test tweaks

* man file updates

* arc2 fixes, use new write to disk setup

* #290 writing to disk work, not done yet

* fixes for lcd and isd tests that also cache files

* fixed some tests #290

* fix storms test

* use relative paths with new vcr version

* move write to disk files to inst/ - test check on travis | ropensci/vcr#164

* try commenting out deleting  user cached files for ersst tests

* comment out one ersst test, does it work now?

* try ersst tests each with different file on disk - was previously using the same file
perhaps that was leading to failure if e.g. file was opened but not closed before next test ran amybe

* remove .Rinstignore, and try inst/test_files in .Rbuildignore if it works on travis

* remove inst/test_files from rbuildignore

* move test files back to tests/files/

* add .Rinstignore for ignoring test on disk files

* woops, needed to fix write_disk_path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant