Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for vcr write to disk path #345

Merged
merged 24 commits into from
Mar 23, 2020
Merged

support for vcr write to disk path #345

merged 24 commits into from
Mar 23, 2020

Conversation

sckott
Copy link
Contributor

@sckott sckott commented Mar 23, 2020

fix #290

sckott added 24 commits July 26, 2019 16:07
@sckott
#290 - working on integrating vcr handling writing to disk, not done yet
80b77fc 
related: ropensci/vcr#81 ropensci/webmockr#57
@sckott
playing with buoy tests, check back in #FIXME
0b4ee8b
@sckott
merge from master
fca9250
@sckott
merge master
045fd44
@sckott
cpc_prcp test tweaks
81872d7
@sckott
merge master changes
119cf17
@sckott
man file updates
1ee18ea
@sckott
arc2 fixes, use new write to disk setup
5e4ccbf
@sckott
#290 writing to disk work, not done yet
f8ad924
@sckott
fixes for lcd and isd tests that also cache files
e1acf73
@sckott
Merge branch 'master' into vcr-write-disk
6944bbf
@sckott
fixed some tests #290
0542c8c
@sckott
fix storms test
9c44a3b
@sckott
use relative paths with new vcr version
3528f75
@sckott
move write to disk files to inst/ - test check on travis | ropensci/v…
135e472 
…cr#164
@sckott
try commenting out deleting user cached files for ersst tests
f123cad
@sckott
comment out one ersst test, does it work now?
b88cb78
@sckott
try ersst tests each with different file on disk - was previously usi…
e33342d 
…ng the same file

perhaps that was leading to failure if e.g. file was opened but not closed before next test ran amybe
@sckott
remove .Rinstignore, and try inst/test_files in .Rbuildignore if it w…
9b095a6 
…orks on travis
@sckott
remove inst/test_files from rbuildignore
6801399
@sckott
move test files back to tests/files/
afbfa58
@sckott
add .Rinstignore for ignoring test on disk files
4ee0235
@sckott
woops, needed to fix write_disk_path
7898eb8
@sckott
merge in master branch changes; use vcr master dev branch
7e51f58
@sckott sckott added this to the v0.9.6 milestone Mar 23, 2020
@sckott sckott merged commit 2a7f09f into master Mar 23, 2020
@sckott sckott deleted the vcr-write-disk branch March 23, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.9.6
Development

Successfully merging this pull request may close these issues.

see if vcr can handle when requests written to disk
1 participant
@sckott