Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noetic Python 2 dependency on wxtools #153

Closed
sloretz opened this issue Oct 22, 2019 · 6 comments · Fixed by #169
Closed

Noetic Python 2 dependency on wxtools #153

sloretz opened this issue Oct 22, 2019 · 6 comments · Fixed by #169

Comments

@sloretz
Copy link
Contributor

sloretz commented Oct 22, 2019

It looks like the noetic source entry for actionlib has a package.xml that depends on the Python 2 rosdep key python-wxtools.

<exec_depend>python-wxtools</exec_depend>

I don't think there is an equivalent rosdep key for Python 3. Can the dependency be eliminated?

@130s
Copy link
Member

130s commented Jan 16, 2020

Not entirely sure but https://stackoverflow.com/a/20614692/577001 says wxpython 4, which seems to be already available via pip, is compatible for both Python 2 and 3. Today I see python-wxtools for Ubuntu Focal is 3.0.2. If I'm correctly seeing the situation, one way to go may be to make a dep rule for focal for pip?

Obviously "cleaner" option might be to update ax{server, client}.py to replace wx with something else (in a similar way done for core GUI tools using qt when rqt was introduced). Looks like those are very light weight GUI so I imagine the coversion will be not hard.

@sloretz
Copy link
Contributor Author

sloretz commented Jan 16, 2020

If I'm correctly seeing the situation, one way to go may be to make a dep rule for focal for pip?

I don't think debian packages can depend on pip packages though. The places where wx is imported would fail if the only thing someone did was install ros-noetic-actionlib.

@130s
Copy link
Member

130s commented Jan 16, 2020

Ah you're right.

Btw not a solution to this issue, but I found #129 is related.

@sloretz
Copy link
Contributor Author

sloretz commented Apr 23, 2020

@mjcarroll friendly ping. It looks like actionlib_tools is released in Noetic with a Python 2 depedency. Mind removing it?

https://github.com/ros-gbp/actionlib-release/blob/debian/ros-noetic-actionlib-tools_1.13.0-1_focal/package.xml#L24

@mjcarroll
Copy link
Member

I'll take a look @sloretz, thanks for the reminder.

@sloretz
Copy link
Contributor Author

sloretz commented Jun 5, 2020

@mjcarroll Might be able to use https://packages.debian.org/buster/python3-wxgtk4.0, but will need a rosdep key

ros/rosdistro#25075 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants