-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add wxpython for bullseye/focal #25075
Conversation
rosdep/python.yaml
Outdated
@@ -6309,6 +6309,7 @@ wxpython: | |||
artful: [python-wxgtk3.0] | |||
bionic: [python-wxgtk3.0] | |||
cosmic: [python-wxgtk3.0] | |||
focal: [python-wxgtk3.0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all of our currently-supported Ubuntu releases, the key is python-wxgtk3.0
. So I think we should just replace this whole block with:
ubuntu: [python-wxgtk3.0]
Which has the added benefit of making us forwards-compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clalancette thanks! chaned to keep both backward/forward compatible
Note that this Debian package depends on Python 2. It shouldn't be used in a package released into Noetic and Foxy because they are both targeting Python 3. |
@sloretz not sure if I understand you comment correctly, 18.04
20.04
|
Yup. Since it depends on Python 2, this rosdep key shouldn't be used by any ROS packages in ROS Noetic or ROS Foxy. If the plan was to release a ROS package into Noetic or Foxy that currently depends on the rosdep key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clalancette has requested a simplification which is only possible by dropping distributions which are no longer supported. I'm in general in favor of that but also fine honoring specific requests from contributors to maintain current levels of support in our rosdep db.
Which is to say, I don't think we should add new keys, or restore dropped keys for older distributions on request since we can instead push individuals who need those to custom rosdep sources. But I don't see a problem with delaying the reduction of support based on contributor feedback.
That logic works for me. I'll re-review here. |
c.f.
https://packages.debian.org/sid/python-wxgtk3.0https://packages.ubuntu.com/focal/python-wxgtk3.0