More reliable topic remapping test #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karsten Knese <[email protected]>
|
CI (rosbag2_transport, retest-until-fail 10):
|
|
The topic remapping test seems to be addressed with this. So I'll put this up for review. |
rosbag2_transport/test/rosbag2_transport/test_play_topic_remap.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Karsten Knese <[email protected]>
|
testing the failing test specifically (test-until-fail 30)
|
emersonknapp
approved these changes
Jul 10, 2020
emersonknapp
pushed a commit
that referenced
this pull request
Feb 2, 2021
* expect only 60 percent of messages to arrive Signed-off-by: Karsten Knese <[email protected]> * test for only one message Signed-off-by: Karsten Knese <[email protected]>
emersonknapp
pushed a commit
that referenced
this pull request
Feb 17, 2021
* expect only 60 percent of messages to arrive Signed-off-by: Karsten Knese <[email protected]> * test for only one message Signed-off-by: Karsten Knese <[email protected]>
emersonknapp
pushed a commit
that referenced
this pull request
Jul 9, 2021
* expect only 60 percent of messages to arrive Signed-off-by: Karsten Knese <[email protected]> * test for only one message Signed-off-by: Karsten Knese <[email protected]>
emersonknapp
pushed a commit
that referenced
this pull request
Jul 9, 2021
* expect only 60 percent of messages to arrive * test for only one message Signed-off-by: Karsten Knese <[email protected]> Signed-off-by: Emerson Knapp <[email protected]>
emersonknapp
added a commit
that referenced
this pull request
Jul 9, 2021
* expect only 60 percent of messages to arrive * test for only one message Signed-off-by: Karsten Knese <[email protected]> Signed-off-by: Emerson Knapp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #455
As mentioned on the issue ticket, as long as we don't have a deterministic execution in ROS2, we can't test for an exact number of messages to be transported.
I lowered the ration of expected messages to only 60 percent, which seems to be fairly reliable and still fulfills the purpose of the test, which is that topics being remapped upon replay.