Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport foxy] More reliable topic remapping test (#456) #817

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

emersonknapp
Copy link
Collaborator

Backport #456 to Foxy. Unreliable test's failures are noise in other backports

* expect only 60 percent of messages to arrive
* test for only one message

Signed-off-by: Karsten Knese <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
@emersonknapp emersonknapp force-pushed the emersonknapp/backport-456-foxy branch from 632d1d3 to 6af986a Compare July 9, 2021 21:47
@emersonknapp
Copy link
Collaborator Author

Gist: https://gist.githubusercontent.com/emersonknapp/17ef223de6110f422434ff2999666433/raw/d1743310f69fb82b636130326be7d600e89bf7c7/ros2.repos
BUILD args: --packages-up-to rosbag2 rosbag2_transport rosbag2_tests
TEST args: --packages-select rosbag2 rosbag2_transport rosbag2_tests
ROS Distro: foxy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/8676

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@emersonknapp
Copy link
Collaborator Author

Windows test failure is from the sigterm test from #809, which was skipped on other distros due to xfail label, which was not yet applied in Foxy. Will address separately but move forward with this stability backport

@emersonknapp emersonknapp merged commit afa04ee into foxy Jul 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the emersonknapp/backport-456-foxy branch July 9, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants