Skip to content

Commit

Permalink
ci: move from manifest to config file (#746)
Browse files Browse the repository at this point in the history
Issue #, if available: release-please action not triggering as expected,
see
[errors](https://github.com/runfinch/finch/actions/runs/7292396775/job/20104474662)
and previous PR (#738)

*Description of changes:*
- I re-read the release-please-action
[documentation](https://github.com/google-github-actions/release-please-action?tab=readme-ov-file#advanced-release-configuration),
and I think I put the config in the wrong file in my previous PR.
- Followed the instructions
[here](https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md)
to create a manifest release since that seems to be what release-please
requires when using a config file on v4
- Moved release-type to the config file instead of the yaml directly
because the action [seems to
branch](https://github.com/google-github-actions/release-please-action/blob/cc61a07e2da466bebbc19b3a7dd01d6aecb20d1e/src/index.ts#L83)
its behavior depending on if that's present or not
 
*Testing done:*
- Tested on my fork, but its hard to replicate the upstream perfectly


- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

---------

Signed-off-by: Justin Alvarez <[email protected]>
  • Loading branch information
pendo324 authored Jan 3, 2024
1 parent 7d1e250 commit f140aa3
Show file tree
Hide file tree
Showing 3 changed files with 60 additions and 27 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/release-please.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,3 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: google-github-actions/release-please-action@v4
with:
release-type: go
26 changes: 1 addition & 25 deletions .release-please-manifest.json
Original file line number Diff line number Diff line change
@@ -1,27 +1,3 @@
{
".": {
"package-name": "finch",
"changelog-sections": [
{
"type": "feat",
"section": "Features",
"hidden": false
},
{
"type": "fix",
"section": "Bug Fixes",
"hidden": false
},
{
"type": "exp",
"section": "Experimental",
"hidden": false
},
{
"type": "build",
"section": "Build System or External Dependencies",
"hidden": false
}
]
}
".": "1.0.1"
}
59 changes: 59 additions & 0 deletions release-please-config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
{
"$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json",
"release-type": "go",
"changelog-sections": [
{
"type": "build",
"section": "Build System or External Dependencies",
"hidden": false
},
{
"type": "exp",
"section": "Experimental",
"hidden": false
},
{
"type": "feat",
"section": "Features",
"hidden": false
},
{
"type": "fix",
"section": "Bug Fixes",
"hidden": false
},
{
"type": "revert",
"section": "Reverts",
"hidden": false
},
{
"type": "chore",
"section": "Miscellaneous Chores",
"hidden": true
},
{
"type": "docs",
"section": "Documentation",
"hidden": true
},
{
"type": "refactor",
"section": "Code Refactoring",
"hidden": true
},
{
"type": "test",
"section": "Tests",
"hidden": true
},
{
"type": "ci",
"section": "Continuous Integration",
"hidden": true
}
],
"packages": {
".": {}
}
}

0 comments on commit f140aa3

Please sign in to comment.