ci: move from manifest to config file #746
Conversation
Signed-off-by: Justin Alvarez <[email protected]>
There was a problem hiding this comment.
I re-read the release-please-action documentation, and I think I put the config in the wrong file in my previous PR.
This link doesn't point to the right place. Did you mean https://github.com/google-github-actions/release-please-action?tab=readme-ov-file#advanced-release-configuration ?
Followed the instructions here to create a manifest release since that seems to be what release-please requires when using a config file on v4
No link for "here", did you mean https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md ?
Yeah, it was a copy/paste error, fixed the links in the original PR, thanks. |
Signed-off-by: Justin Alvarez <[email protected]>
Issue #, if available: Release please created "duplicate" PRs: #104 and #107. This is because of the update to major version 4. We saw similar issues in the main finch repo (see runfinch/finch#746), so this is just porting over those changes. *Description of changes:* - Update release-please config - pin actions to SHAs *Testing done:* - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Justin Alvarez <[email protected]>
Issue #, if available: release-please action not triggering as expected, see errors and previous PR (#738)
Description of changes:
Testing done:
Tested on my fork, but its hard to replicate the upstream perfectly
I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.