ci: update release-please action config to work with v4 #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Alvarez <[email protected]>
KevinLiAWS
approved these changes
Dec 14, 2023
|
Overriding CI since this is just a CI dependency change |
1 task
pendo324
added a commit
that referenced
this pull request
Jan 3, 2024
Issue #, if available: release-please action not triggering as expected, see [errors](https://github.com/runfinch/finch/actions/runs/7292396775/job/20104474662) and previous PR (#738) *Description of changes:* - I re-read the release-please-action [documentation](https://github.com/google-github-actions/release-please-action?tab=readme-ov-file#advanced-release-configuration), and I think I put the config in the wrong file in my previous PR. - Followed the instructions [here](https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md) to create a manifest release since that seems to be what release-please requires when using a config file on v4 - Moved release-type to the config file instead of the yaml directly because the action [seems to branch](https://github.com/google-github-actions/release-please-action/blob/cc61a07e2da466bebbc19b3a7dd01d6aecb20d1e/src/index.ts#L83) its behavior depending on if that's present or not *Testing done:* - Tested on my fork, but its hard to replicate the upstream perfectly - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: Justin Alvarez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Our release-please GH action version was recently bumped from v3 to v4 by a dependabot PR merge. Since then, we've merged subsequent PRs but haven't had a new automated release PR be created by the bot. This seems to be caused by the breaking changes described here.
This PR tries to migrate our config to work with version 4 of release-please.
Testing done:
It's kinda hard to test this since the action runs remotely and uses the GitHub repo itself as input. If anyone has an idea of how to test this that can be done before merging this PR, lmk and I can try it. Otherwise, seems pretty low-risk to merge and see what happens.
I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.