Repoint cc dep in bootstrap to its latest version. #134344

lasiotus · 2024-12-15T16:58:11Z

v1.2.4 handles new/unofficial targets much better than v1.2.0.

More specifically, v1.2.4 allows using env vars to pass target parameters to cc crate, as discussed in rust-lang/cc-rs#1317. With v1.2.0, unofficial targets like Motor OS cannot easily rebase to the current rust-lang and have to stay at an older version.

Also bump cmake's version from 0.1.48 to 0.1.52, as it is linked to cc.

cc-rs changelogs:

1.2.4
1.2.3
1.2.2
1.2.1

cmake changelogs/releases:

0.1.52
0.1.51
0.1.50: not a release
0.1.49

v1.2.4 handles new/unofficial targets much better than v1.2.0. Also bump cmake's version, as it is linked to cc.

rustbot · 2024-12-15T16:58:20Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jieyouxu (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

jieyouxu · 2024-12-15T17:59:41Z

@lasiotus could you link to the relnotes for cc and cmake between

cc = "=1.2.0" and cc = "=1.2.4"
cmake = "=0.1.48" and cmake = "=0.1.52"

in the PR description? That way, (1) I have some clue what these bumps entail and (2) if something regresses, we are more likely to know which changes are responsible.

As you may have noticed, we pin these since

# Most of the time updating these dependencies requires modifications to the
# bootstrap codebase(e.g., https://github.com/rust-lang/rust/issues/124565);
# otherwise, some targets will fail. That's why these dependencies are explicitly pinned.

v1.2.4 handles new/unofficial targets much better than v1.2.0.

Can you elaborate on which targets (please also just include that info in PR description for git archaeology purposes)?

@rustbot author

jieyouxu · 2024-12-15T18:09:04Z

You know what, let's just see what breaks.

@bors r+ rollup=never

bors · 2024-12-15T18:09:07Z

📌 Commit f396e87 has been approved by jieyouxu

It is now in the queue for this repository.

lasiotus · 2024-12-15T18:26:12Z

@lasiotus could you link to the relnotes for cc and cmake between

cc = "=1.2.0" and cc = "=1.2.4"

cmake = "=0.1.48" and cmake = "=0.1.52"

in the PR description? That way, (1) I have some clue what these bumps entail and (2) if something regresses, we are more likely to know which changes are responsible.

As you may have noticed, we pin these since
# Most of the time updating these dependencies requires modifications to the
# bootstrap codebase(e.g., https://github.com/rust-lang/rust/issues/124565);
# otherwise, some targets will fail. That's why these dependencies are explicitly pinned.
v1.2.4 handles new/unofficial targets much better than v1.2.0.

Can you elaborate on which targets (please also just include that info in PR description for git archaeology purposes)?

@rustbot author

Done.

clubby789 · 2024-12-15T18:29:50Z

FYI, a cc update to 1.2.4 (most likely) was the culprit for a failure here

jieyouxu · 2024-12-15T18:30:02Z

Thanks!

jieyouxu · 2024-12-15T18:31:29Z

Let's see if it's still a problem.

NobodyXu · 2024-12-15T22:27:53Z

1.2.2 - 2024-11-29

Fetch target info from Cargo even if Build::target is manually set (#1299)

Based on the changelog, I believe 1.2.2 is the first release that allows using env vars to pass target parameters to cc crate

bors · 2024-12-16T04:35:02Z

⌛ Testing commit f396e87 with merge 1a0bdd7...

rust-log-analyzer · 2024-12-16T05:36:45Z

The job dist-x86_64-msvc failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[2024-12-16T05:26:50Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2024-12-16T05:26:50Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Check, scenario=Some(Full), patch=None, backend=Llvm, phase=benchmark
[2024-12-16T05:26:50Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpqQtZHR#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln"
[2024-12-16T05:26:56Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Check, scenario=Some(IncrFull), patch=None, backend=Llvm, phase=benchmark
[2024-12-16T05:26:57Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpqQtZHR#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpqQtZHR\\incremental-state"
[2024-12-16T05:27:04Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Check, scenario=Some(IncrUnchanged), patch=None, backend=Llvm, phase=benchmark
[2024-12-16T05:27:04Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpqQtZHR#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpqQtZHR\\incremental-state"
[2024-12-16T05:27:06Z DEBUG collector::compile::benchmark::patch] applying println to "C:\\a\\_temp\\msys64\\tmp\\.tmpqQtZHR"
[2024-12-16T05:27:06Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Check, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" }), backend=Llvm, phase=benchmark
[2024-12-16T05:27:06Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Check, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" }), backend=Llvm, phase=benchmark
[2024-12-16T05:27:06Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpqQtZHR#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpqQtZHR\\incremental-state"
[2024-12-16T05:27:09Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2024-12-16T05:27:09Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Debug, scenario=Some(Full), patch=None, backend=Llvm, phase=benchmark
[2024-12-16T05:27:09Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpTYrEuc#[email protected]" "--" "--wrap-rustc-with" "Eprintln"
[2024-12-16T05:27:16Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrFull), patch=None, backend=Llvm, phase=benchmark
---
[2024-12-16T05:27:53Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2024-12-16T05:27:53Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Check, scenario=Some(Full), patch=None, backend=Llvm, phase=benchmark
[2024-12-16T05:27:53Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpmDzEdn#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln"
[2024-12-16T05:27:53Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Check, scenario=Some(IncrFull), patch=None, backend=Llvm, phase=benchmark
[2024-12-16T05:27:53Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpmDzEdn#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpmDzEdn\\incremental-state"
[2024-12-16T05:27:54Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Check, scenario=Some(IncrUnchanged), patch=None, backend=Llvm, phase=benchmark
[2024-12-16T05:27:54Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpmDzEdn#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpmDzEdn\\incremental-state"
[2024-12-16T05:27:54Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2024-12-16T05:27:54Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Debug, scenario=Some(Full), patch=None, backend=Llvm, phase=benchmark
[2024-12-16T05:27:54Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmp5ImrI4#[email protected]" "--" "--wrap-rustc-with" "Eprintln"
[2024-12-16T05:27:55Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrFull), patch=None, backend=Llvm, phase=benchmark
---
   Compiling rustc_driver v0.0.0 (C:\a\rust\rust\compiler\rustc_driver)
[RUSTC-TIMING] rustc_driver test:false 4.817
error: linking with `link.exe` failed: exit code: 1104
  |
  = note: "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\bin\\HostX64\\x64\\link.exe" "/NOLOGO" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\symbols.o" "<1 object files omitted>" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\deps\\rustc_driver-275573641986a9c6.dll.lib" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib/{libcompiler_builtins-c25bba97e86b102c.rlib}" "psapi.lib" "shell32.lib" "ole32.lib" "uuid.lib" "advapi32.lib" "ws2_32.lib" "ntdll.lib" "kernel32.lib" "advapi32.lib" "ole32.lib" "oleaut32.lib" "advapi32.lib" "cfgmgr32.lib" "gdi32.lib" "kernel32.lib" "msimg32.lib" "opengl32.lib" "user32.lib" "winspool.lib" "bcrypt.lib" "advapi32.lib" "legacy_stdio_definitions.lib" "kernel32.lib" "kernel32.lib" "advapi32.lib" "ntdll.lib" "userenv.lib" "ws2_32.lib" "dbghelp.lib" "/defaultlib:libcmt" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\advapi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\api-ms-win-core-errorhandling-l1-1-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\api-ms-win-core-file-fromapp-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\api-ms-win-core-handle-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\api-ms-win-core-ioring-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\api-ms-win-core-memory-l1-1-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\api-ms-win-core-memory-l1-1-4.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\api-ms-win-core-memory-l1-1-5.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\api-ms-win-core-memory-l1-1-6.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\api-ms-win-core-memory-l1-1-7.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\api-ms-win-core-memory-l1-1-8.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\api-ms-win-core-synch-l1-2-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\api-ms-win-core-sysinfo-l1-2-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\api-ms-win-core-sysinfo-l1-2-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\api-ms-win-core-sysinfo-l1-2-4.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\api-ms-win-core-sysinfo-l1-2-6.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\api-ms-win-core-util-l1-1-1.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\api-ms-win-core-winrt-error-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\api-ms-win-core-winrt-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\api-ms-win-core-wow64-l1-1-1.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\api-ms-win-security-base-l1-2-2.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\avrt.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\bcp47mrm.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\bcryptprimitives.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\clfsw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\dbghelp.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\elscore.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\gdi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\icu.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\imagehlp.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\kernel32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\ktmw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\netapi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\normaliz.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\ntdll.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\ntdllk.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\ole32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\oleacc.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\oleaut32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\propsys.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\psapi.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\rtworkq.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\txfw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\user32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\usp10.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\version.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcOZIGkz\\wofutil.dll_imports_indirect.lib" "/NXCOMPAT" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\stacker-51665ada3368c7c5\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\psm-49e517f07a604d4e\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\blake3-9f5cbfe9164854a2\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\blake3-9f5cbfe9164854a2\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\rustc_llvm-2e0139d76762918c\\out" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\llvm\\lib" "/OUT:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\deps\\rustc_main-eab8b601f1552337.exe" "/OPT:REF,ICF" "/DEBUG" "/PDBALTPATH:%_PDB%" "/MANIFEST:EMBED" "/MANIFESTINPUT:C:\\a\\rust\\rust\\compiler\\rustc\\Windows Manifest.xml" "/WX"
  = note: LINK : fatal error LNK1104: cannot open file 'C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-rustc\x86_64-pc-windows-msvc\release\deps\rustc_main-eab8b601f1552337.exe'␍
          

[RUSTC-TIMING] rustc_main test:false 0.653

bors · 2024-12-16T05:37:29Z

💔 Test failed - checks-actions

jieyouxu · 2024-12-16T06:31:59Z

No, that is not the failure I was expecting.
@bors retry (msvc usual something holding on to file problem)

bors · 2024-12-16T06:34:20Z

⌛ Testing commit f396e87 with merge e2494ec...

rust-log-analyzer · 2024-12-16T08:24:47Z

The job dist-apple-various failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2024-12-16T08:25:26Z

💔 Test failed - checks-actions

jieyouxu · 2024-12-16T08:32:47Z

2024-12-16T08:24:34.9104890Z could not determine CMAKE_SYSTEM_NAME from the target `aarch64-apple-ios`, build may fail
2024-12-16T08:24:34.9107480Z CMAKE_TOOLCHAIN_FILE_aarch64-apple-ios = None
2024-12-16T08:24:34.9109170Z CMAKE_TOOLCHAIN_FILE_aarch64_apple_ios = None
2024-12-16T08:24:34.9111250Z TARGET_CMAKE_TOOLCHAIN_FILE = None
2024-12-16T08:24:34.9116590Z CMAKE_TOOLCHAIN_FILE = None
2024-12-16T08:24:34.9120130Z thread 'main' panicked at /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cmake-0.1.52/src/lib.rs:1115:5:
2024-12-16T08:24:34.9121100Z 
2024-12-16T08:24:34.9121380Z environment variable `CARGO_CFG_TARGET_OS` not defined
2024-12-16T08:24:34.9121820Z 
2024-12-16T08:24:34.9122030Z build script failed, must exit now

jieyouxu · 2024-12-16T08:32:54Z

@bors r-

jieyouxu · 2024-12-20T11:49:09Z

I'm going to reroll a bootstrap reviewer because I don't currently have the bandwidth to help diagnose a cc/cmake bump failure.

r? bootstrap

clubby789 · 2024-12-20T13:47:39Z

Going to try and look into this today with #134558

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

clubby789 · 2024-12-27T18:19:43Z

Details in the PR, but current status is that rust-lang/cmake-rs@d668808 regressed, as we don't provide CMAKE_SYSTEM_NAME on iOS. Further investigation from someone with a Mac would be appreciated

Repoint cc dep in bootstrap to its latest version.

f396e87

v1.2.4 handles new/unofficial targets much better than v1.2.0. Also bump cmake's version, as it is linked to cc.

rustbot assigned jieyouxu Dec 15, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 15, 2024

This was referenced Dec 15, 2024

Cannot move to a newer Rust version moturus/motor-os#18

Open

Discussion: Reconsider target parsing rust-lang/cc-rs#1317

Open

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 15, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 16, 2024

jieyouxu added the CI-spurious-fail-msvc CI spurious failure: target env msvc label Dec 16, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 16, 2024

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2024

lasiotus mentioned this pull request Dec 17, 2024

Latest versions break rust-lang bootstrap rust-lang/cmake-rs#228

Open

rustbot assigned albertlarsan68 and unassigned jieyouxu Dec 20, 2024

clubby789 mentioned this pull request Dec 20, 2024

[EXPERIMENTAL] Bisect cmake bootstrap issue #134558

Closed

clubby789 assigned clubby789 and unassigned albertlarsan68 Dec 20, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024

Auto merge of rust-lang#134558 - clubby789:cmake-bisect, r=<try>

61c63b9

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024

Auto merge of rust-lang#134558 - clubby789:cmake-bisect, r=<try>

149f420

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024

Auto merge of rust-lang#134558 - clubby789:cmake-bisect, r=<try>

46520ed

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024

Auto merge of rust-lang#134558 - clubby789:cmake-bisect, r=<try>

34774f8

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024

Auto merge of rust-lang#134558 - clubby789:cmake-bisect, r=<try>

653536d

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 21, 2024

Auto merge of rust-lang#134558 - clubby789:cmake-bisect, r=<try>

4039363

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 21, 2024

Auto merge of rust-lang#134558 - clubby789:cmake-bisect, r=<try>

f048f9e

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 21, 2024

Auto merge of rust-lang#134558 - clubby789:cmake-bisect, r=<try>

583f4f0

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 21, 2024

Auto merge of rust-lang#134558 - clubby789:cmake-bisect, r=<try>

0f380ea

[EXPERIMENTAL] Bisect cmake bootstrap issue r? `@ghost` Investigating rust-lang#134344 try-job: dist-apple-various

jieyouxu mentioned this pull request Jan 8, 2025

"error occurred: unknown target" when trying to add a new target #135271

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Repoint cc dep in bootstrap to its latest version. #134344

Repoint cc dep in bootstrap to its latest version. #134344

lasiotus commented Dec 15, 2024 •

edited

Loading

rustbot commented Dec 15, 2024

jieyouxu commented Dec 15, 2024

jieyouxu commented Dec 15, 2024

bors commented Dec 15, 2024

lasiotus commented Dec 15, 2024

clubby789 commented Dec 15, 2024

jieyouxu commented Dec 15, 2024

jieyouxu commented Dec 15, 2024

NobodyXu commented Dec 15, 2024

bors commented Dec 16, 2024

rust-log-analyzer commented Dec 16, 2024

bors commented Dec 16, 2024

jieyouxu commented Dec 16, 2024

bors commented Dec 16, 2024

rust-log-analyzer commented Dec 16, 2024

bors commented Dec 16, 2024

jieyouxu commented Dec 16, 2024

jieyouxu commented Dec 16, 2024

jieyouxu commented Dec 20, 2024

clubby789 commented Dec 20, 2024

clubby789 commented Dec 27, 2024

Repoint cc dep in bootstrap to its latest version. #134344

Are you sure you want to change the base?

Repoint cc dep in bootstrap to its latest version. #134344

Conversation

lasiotus commented Dec 15, 2024 • edited Loading

rustbot commented Dec 15, 2024

jieyouxu commented Dec 15, 2024

jieyouxu commented Dec 15, 2024

bors commented Dec 15, 2024

lasiotus commented Dec 15, 2024

clubby789 commented Dec 15, 2024

jieyouxu commented Dec 15, 2024

jieyouxu commented Dec 15, 2024

NobodyXu commented Dec 15, 2024

bors commented Dec 16, 2024

rust-log-analyzer commented Dec 16, 2024

bors commented Dec 16, 2024

jieyouxu commented Dec 16, 2024

bors commented Dec 16, 2024

rust-log-analyzer commented Dec 16, 2024

bors commented Dec 16, 2024

jieyouxu commented Dec 16, 2024

jieyouxu commented Dec 16, 2024

jieyouxu commented Dec 20, 2024

clubby789 commented Dec 20, 2024

clubby789 commented Dec 27, 2024

lasiotus commented Dec 15, 2024 •

edited

Loading