-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync in portable-simd subtree #99491
Conversation
Co-authored-by: Jacob Lifshay <[email protected]>
…r and mask types This is a documentation-only patch that standardizes the presentation of vector types like `u32x4` and mask types like `mask32x16`. The reasoning behind the patch was as follows: 1. Standardized terminology should be preferred, so `element` instead of `value` and `SIMD vector` instead of `vector`. These terms appear in the rest of the documentation and tutorials. 2. Try to avoid situations where two numbers are next to each other. So `16 elements of 32 bits` instead of `16 32-bit elements`. 4. Try to anticipate what readers are looking for -- so state the full bit-width directly. ### Vector Types - Before: Vector of 32 `i8` values - After: A 256-bit SIMD vector with 32 elements of type `i8`. ### Mask Types - Before: Vector of 16 16-bit masks - After: A mask for SIMD vectors with 16 elements of 32 bits.
A simpler variant of rust-lang/portable-simd#206. * Comparisons are moved to `SimdPartialEq`, `SimdPartialOrd`, and `SimdOrd`. The function names are prefixed with `simd_` to disambiguate from the regular `PartialEq` etc functions. With the functions on traits instead of `Simd` directly, shadowing the function names doesn't work very well. * Floating point `Ord`-like functions are put into a `SimdFloat` trait. The intention is that eventually (some time after this PR) all floating point functions will be moved from `Simd` to `SimdFloat`, and the same goes for future `SimdInt`/`SimdUint` traits.
…s, swizzle Working through giving example documentation to every Simd function. The major change in this patch is using doc macros to generate type-specific examples for each function, using a visually-apparent type constructor. This makes it feel nicer to have twelve separate documentation entries for reduce_product(), for example.
…imd_mut() This links to a practical suggestion for how to solve the issues brought up in this section.
Add Mask::cast
Move element-specific functions to traits
Add bitmask array
This fixes poor codegen in some circumstances for `u16x8::splat` on x86_64 https://rust-lang.zulipchat.com/#narrow/stream/257879-project-portable-simd/topic/Very.20bad.20.60u16x8.3A.3Asplat.60.20codegen.20on.20x86_64
Deduplicate to_int_unchecked
Change `Simd::splat` to not generate a loop
It looks like the last time had left some remaining cfg's -- which made me think that the stage0 bump was actually successful. This brings us to a released 1.62 beta though.
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
This comment has been minimized.
This comment has been minimized.
Within core, `use self::` does not work to import these items. And because core is not core_simd, neither does the existing `use`. So, use this quirky hack instead, switching the import on a feature.
0578e51
to
f8aa494
Compare
@bors r+ |
@bors rollup=never |
☀️ Test successful - checks-actions |
Finished benchmarking commit (41419e7): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Footnotes |
...I got nothin'! I like genuinely have no idea why any of these changes, tbh. |
r? @ghost