Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc5 support resolves #240 #265

Merged
merged 4 commits into from
Jan 30, 2025
Merged

sc5 support resolves #240 #265

merged 4 commits into from
Jan 30, 2025

Conversation

waggledans
Copy link
Contributor

@waggledans waggledans commented Aug 23, 2024

One-line summary

Upgrade to Sauce Connect 5. This is a breaking change.

Issue : #240

Description

Sauce Connect 5 is the latest and supported version of Sauce Connect. This update provides support for Sauce Connect 5, and removes support for Sauce Connect 4.x.x.

Running Sauce Connect 5 client

# ./bin/sl sc --region us --tunnel-name node-saucelabs-test
2025/01/28 01:19:52.901099 [control] [INFO] Sauce Connect Proxy version=5.2.2
2025/01/28 01:19:52.901482 [control] [INFO] configuration
2025/01/28 01:19:52.901540 [proxy] [INFO] no upstream proxy specified
2025/01/28 01:19:52.901543 [proxy] [INFO] localhost proxying mode=deny
2025/01/28 01:19:52.901664 [control] [INFO] please wait for 'you may start your tests' to start your tests
2025/01/28 01:19:52.901666 [control] [INFO] provisioning Sauce Connect region=us-west name=node-saucelabs-test
...
2025/01/28 01:20:06.015227 [control] [INFO] Sauce Connect is up, you may start your tests

Calling scDownload API endpoint

# ./bin/sl scDownload --os linux --arch x86_64
{
    "download": {
        "checksums": [
            {
                "value": "2724245e9eff8eb81610a34f1d4c3f7b15dce67aa37a31d6b32dc888427982a5",
                "algorithm": "sha256"
            }
        ],
        "url": "https://saucelabs.com/downloads/sauce-connect/5.2.2/sauce-connect-5.2.2_linux.x86_64.tar.gz",
        "version": "5.2.2"
    }
}

Types of Changes

What types of changes does your code introduce? Keep the ones that apply:

  • New feature (breaking change which adds functionality)

Review

List of tasks the reviewer must do to review the PR

  • Tests
  • Documentation

src/utils.js Outdated Show resolved Hide resolved
@amckenzie132 amckenzie132 force-pushed the dans-sc5 branch 2 times, most recently from bbfbd93 to 507c7e5 Compare January 28, 2025 01:25
@budziam
Copy link
Contributor

budziam commented Jan 28, 2025

Please provide a an easy way to pass --metadata runner=XYZ. This will greatly help us identify the platform used to run an SC client. For reference, here's how it was implemented in the java library: https://github.com/saucelabs/ci-sauce/blob/main/src/main/java/com/saucelabs/ci/sauceconnect/SauceConnectManager.java#L364.

src/index.js Show resolved Hide resolved
@budziam budziam merged commit da311f5 into main Jan 30, 2025
6 checks passed
@budziam budziam deleted the dans-sc5 branch January 30, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants