-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sc5 support resolves #240 #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waggledans
force-pushed
the
dans-sc5
branch
5 times, most recently
from
August 27, 2024 18:24
7b92f0d
to
78b2aea
Compare
amckenzie132
force-pushed
the
dans-sc5
branch
from
January 26, 2025 20:08
12a0fa2
to
6283bec
Compare
waggledans
commented
Jan 27, 2025
amckenzie132
force-pushed
the
dans-sc5
branch
2 times, most recently
from
January 28, 2025 01:25
bbfbd93
to
507c7e5
Compare
amckenzie132
force-pushed
the
dans-sc5
branch
from
January 28, 2025 02:05
507c7e5
to
04817a3
Compare
Please provide a an easy way to pass --metadata runner=XYZ. This will greatly help us identify the platform used to run an SC client. For reference, here's how it was implemented in the java library: https://github.com/saucelabs/ci-sauce/blob/main/src/main/java/com/saucelabs/ci/sauceconnect/SauceConnectManager.java#L364. |
budziam
reviewed
Jan 28, 2025
budziam
reviewed
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Upgrade to Sauce Connect 5. This is a breaking change.
Description
Sauce Connect 5 is the latest and supported version of Sauce Connect. This update provides support for Sauce Connect 5, and removes support for Sauce Connect 4.x.x.
scDownload
for Sauce Connect 5 client download infoscVersions
Running Sauce Connect 5 client
Calling scDownload API endpoint
Types of Changes
What types of changes does your code introduce? Keep the ones that apply:
Review
List of tasks the reviewer must do to review the PR