Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tensorrt_llm common and cutlass_extensions as 3rdparty #3216

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

zhyncs
Copy link
Member

@zhyncs zhyncs commented Jan 30, 2025

Motivation

Modifications

Checklist

@BBuf
Copy link
Collaborator

BBuf commented Jan 30, 2025

Will the common library be compiled and linked automatically?

@zhyncs
Copy link
Member Author

zhyncs commented Jan 30, 2025

Will the common library be compiled and linked automatically?

It's safe to merge since we haven't used any components yet. I will do this in a follow-up.

@zhyncs
Copy link
Member Author

zhyncs commented Jan 30, 2025

Q: Why not directly use tensorrt llm as a third_party managed by git submodule?
A: Because tensorrt llm itself is too large and has many dependencies. If used as a git submodule, installing and downloading it would either take up too much disk space or be too time-consuming.

@zhyncs zhyncs merged commit 222ce6f into main Jan 30, 2025
4 of 5 checks passed
@zhyncs zhyncs deleted the zhyncs/trt branch January 30, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants