Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background transparency is not applied for Teletext subtitle if we disabled the transparency for default transparency available txt subtitle asset #4468

Closed
Suruthi-11 opened this issue Sep 6, 2022 · 1 comment · Fixed by #4496 or #4424
Closed

Background transparency is not applied for Teletext subtitle if we disabled the transparency for default transparency available txt subtitle asset #4468

Suruthi-11 opened this issue Sep 6, 2022 · 1 comment · Fixed by #4496 or #4424
Assignees
@joeyparrish
Labels
component: TTML The issue involves TTML subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v4.3

Comments

@Suruthi-11
Copy link

Suruthi-11 commented Sep 6, 2022 •
edited by joeyparrish
Loading

Have you read the FAQ and checked for duplicate open issues?
yes

What link can we use to reproduce this?
https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;panel=HOME;build=uncompiled

What version of Shaka Player are you using?
v4.2.1-uncompiled

What browser and OS are you using?
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.0.0 Safari/537.36

What did you do?

  1. Playback one teletext live asset mpd on shaka player
  2. enabled the subtitle CC
  3. Verify the subtitle decoding and ensure the background transpareny

What did you expect to happen?
Background color should not be applied for teletext subtitle if there is no subtitle background applied

What actually happened?
In the logs i cannot see any background color attribute but background applied in playback screen

example subtitle xml:

<tt xmlns="http://www.w3.org/ns/ttml"
    xmlns:smpte="http://www.smpte-ra.org/schemas/2052-1/2010/smpte-tt"
    xmlns:ttm="http://www.w3.org/ns/ttml#metadata"
    xmlns:ttp="http://www.w3.org/ns/ttml#parameter"
    xmlns:tts="http://www.w3.org/ns/ttml#styling"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="http://www.smpte-ra.org/schemas/2052-1/2010/smpte-tt http://www.smpte-ra.org/schemas/2052-1/2010/smpte-tt.xsd">
  <head>
    <styling>
         <style xml:id="style_1" tts:color="rgb(255,255,255)"/>
    </styling>
  </head>
  <body>
    <div>
      <p begin="461672:55:46.000" end="461672:55:47.153"><span style="style_1">               She wants her performance</span></p>
      <p begin="461672:55:46.000" end="461672:55:47.153"><span style="style_1">                   to be authentic.     </span></p>
      <p begin="461672:55:47.173" end="461672:55:48.000"><span style="style_1">      Mnh-mnh. I&apos;d rather swallow       </span></p>
      <p begin="461672:55:47.193" end="461672:55:48.000"><span style="style_1">             razor blades.              </span></p>
    </div>
  </body>
</tt>
@joeyparrish joeyparrish added type: bug Something isn't working correctly component: TTML The issue involves TTML subtitles specifically priority: P2 Smaller impact or easy workaround labels Sep 20, 2022
@joeyparrish joeyparrish self-assigned this Sep 20, 2022
@joeyparrish
Copy link
Member

The IMSC1 renderer at https://www.sandflow.com/imsc1_1/index.html and the TTML spec both agree with you. Background should default to transparent.

This will be handled in the TTML parser if at all possible, to avoid changing defaults for other formats.

joeyparrish added a commit to joeyparrish/shaka-player that referenced this issue Sep 20, 2022
@joeyparrish
fix(ttml): Default background color to transparent if unspecified
4cd5612 
Closes shaka-project#4468
@joeyparrish joeyparrish mentioned this issue Sep 20, 2022
Merged
@github-actions github-actions bot added this to the v4.3 milestone Sep 20, 2022
joeyparrish added a commit that referenced this issue Sep 28, 2022
@joeyparrish
fix(ttml): Default TTML background color to transparent if unspecified (
32b0a90 
#4496)

Closes #4468
@github-actions github-actions bot mentioned this issue Sep 28, 2022
Merged
JulianDomingo pushed a commit that referenced this issue Oct 6, 2022
@joeyparrish @JulianDomingo
fix(ttml): Default TTML background color to transparent if unspecified (
0b5c985 
#4496)

Closes #4468
@github-actions github-actions bot mentioned this issue Oct 6, 2022
Merged
JulianDomingo pushed a commit that referenced this issue Oct 6, 2022
@joeyparrish @JulianDomingo
fix(ttml): Default TTML background color to transparent if unspecified (
16da1e7 
#4496)

Closes #4468
@github-actions github-actions bot mentioned this issue Oct 6, 2022
Merged
JulianDomingo pushed a commit that referenced this issue Oct 7, 2022
@joeyparrish @JulianDomingo
fix(ttml): Default TTML background color to transparent if unspecified (
862ee42 
#4496)

Closes #4468
@github-actions github-actions bot mentioned this issue Oct 7, 2022
Merged
JulianDomingo pushed a commit that referenced this issue Oct 7, 2022
@joeyparrish @JulianDomingo
fix(ttml): Default TTML background color to transparent if unspecified (
0c6ad6d 
#4496)

Closes #4468
@github-actions github-actions bot mentioned this issue Oct 7, 2022
Merged
JulianDomingo pushed a commit that referenced this issue Oct 7, 2022
@github-actions
chore(v3.2.x): release 3.2.13 (#4557)
16ba6cd 
🤖 I have created a release *beep* *boop*
---


##
[3.2.13](v3.2.12...v3.2.13)
(2022-10-07)


### Bug Fixes

* allow build without text
([#4506](#4506))
([5f3afd4](5f3afd4))
* allow the playback on platforms when low latency APIs are not
supported
([#4485](#4485))
([0239aa5](0239aa5))
* check for negative rows before moving
([#4510](#4510))
([12e3305](12e3305)),
closes
[#4508](#4508)
* Filter unsupported H.264 streams in Xbox
([#4493](#4493))
([ea02766](ea02766))
* Fix hang when seeking to the last segment
([#4537](#4537))
([951aaea](951aaea))
* Respect existing app usage of Cast SDK
([#4523](#4523))
([da5fd15](da5fd15)),
closes
[#4521](#4521)
* **ttml:** Default TTML background color to transparent if unspecified
([#4496](#4496))
([0c6ad6d](0c6ad6d)),
closes
[#4468](#4468)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
JulianDomingo pushed a commit that referenced this issue Oct 7, 2022
@github-actions
chore(v3.3.x): release 3.3.11 (#4556)
791041b 
🤖 I have created a release *beep* *boop*
---


##
[3.3.11](v3.3.10...v3.3.11)
(2022-10-07)


### Bug Fixes

* allow build without text
([#4506](#4506))
([5014c1d](5014c1d))
* allow the playback on platforms when low latency APIs are not
supported
([#4485](#4485))
([c0fc0b4](c0fc0b4))
* check for negative rows before moving
([#4510](#4510))
([359b63e](359b63e)),
closes
[#4508](#4508)
* Filter unsupported H.264 streams in Xbox
([#4493](#4493))
([21ee94f](21ee94f))
* Fix hang when seeking to the last segment
([#4537](#4537))
([2868e12](2868e12))
* Respect existing app usage of Cast SDK
([#4523](#4523))
([d2258d6](d2258d6)),
closes
[#4521](#4521)
* **ttml:** Default TTML background color to transparent if unspecified
([#4496](#4496))
([862ee42](862ee42)),
closes
[#4468](#4468)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
JulianDomingo pushed a commit that referenced this issue Oct 7, 2022
@github-actions
chore(v4.1.x): release 4.1.5 (#4555)
3279ad4 
🤖 I have created a release *beep* *boop*
---


##
[4.1.5](v4.1.4...v4.1.5)
(2022-10-07)


### Bug Fixes

* allow build without text
([#4506](#4506))
([1db6265](1db6265))
* allow the playback on platforms when low latency APIs are not
supported
([#4485](#4485))
([55d1390](55d1390))
* check for negative rows before moving
([#4510](#4510))
([31abae3](31abae3)),
closes
[#4508](#4508)
* Filter unsupported H.264 streams in Xbox
([#4493](#4493))
([1ecede6](1ecede6))
* Fix choppy HLS startup
([#4553](#4553))
([1675bff](1675bff)),
closes
[#4516](#4516)
* Fix errors with TS segments on Chromecast
([#4543](#4543))
([15a1c60](15a1c60))
* Fix hang when seeking to the last segment
([#4537](#4537))
([72a119d](72a119d))
* Fix HLS dynamic to static transition
([932d37c](932d37c))
* Fix HLS dynamic to static transition
([#4483](#4483))
([932d37c](932d37c)),
closes
[#4431](#4431)
* Fix in-band key rotation on Xbox One
([#4478](#4478))
([5a8f09c](5a8f09c)),
closes
[#4401](#4401)
* Respect existing app usage of Cast SDK
([#4523](#4523))
([9c3a494](9c3a494)),
closes
[#4521](#4521)
* **ttml:** Default TTML background color to transparent if unspecified
([#4496](#4496))
([16da1e7](16da1e7)),
closes
[#4468](#4468)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
JulianDomingo pushed a commit that referenced this issue Oct 7, 2022
@github-actions
chore(v4.2.x): release 4.2.2 (#4554)
cf836a4 
🤖 I have created a release *beep* *boop*
---


##
[4.2.2](v4.2.1...v4.2.2)
(2022-10-07)


### Bug Fixes

* allow build without text
([#4506](#4506))
([7e93720](7e93720))
* allow the playback on platforms when low latency APIs are not
supported
([#4485](#4485))
([cf8c857](cf8c857))
* check for negative rows before moving
([#4510](#4510))
([23f39d7](23f39d7)),
closes
[#4508](#4508)
* Filter unsupported H.264 streams in Xbox
([#4493](#4493))
([914a08a](914a08a))
* Fix choppy HLS startup
([#4553](#4553))
([950ce69](950ce69)),
closes
[#4516](#4516)
* Fix errors with TS segments on Chromecast
([#4543](#4543))
([8204db6](8204db6))
* Fix hang when seeking to the last segment
([#4537](#4537))
([3d6c768](3d6c768))
* Fix HLS dynamic to static transition
([d9ecbf3](d9ecbf3))
* Fix HLS dynamic to static transition
([#4483](#4483))
([d9ecbf3](d9ecbf3)),
closes
[#4431](#4431)
* Fix in-band key rotation on Xbox One
([#4478](#4478))
([bc0a588](bc0a588)),
closes
[#4401](#4401)
* Missing AES-128 key of last HLS segment
([#4519](#4519))
([2c2677f](2c2677f)),
closes
[#4517](#4517)
* Respect existing app usage of Cast SDK
([#4523](#4523))
([3db2568](3db2568)),
closes
[#4521](#4521)
* **ttml:** Default TTML background color to transparent if unspecified
([#4496](#4496))
([0b5c985](0b5c985)),
closes
[#4468](#4468)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Nov 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
component: TTML The issue involves TTML subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.3
2 participants
@joeyparrish @Suruthi-11