-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accommodate pre-existing __onGCastApiAvailable #4521
Labels
priority: P2
Smaller impact or easy workaround
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
type: enhancement
New feature or request
Milestone
Comments
joeyparrish
added
type: bug
Something isn't working correctly
priority: P2
Smaller impact or easy workaround
labels
Sep 29, 2022
joeyparrish
pushed a commit
that referenced
this issue
Oct 4, 2022
JulianDomingo
pushed a commit
that referenced
this issue
Oct 6, 2022
JulianDomingo
pushed a commit
that referenced
this issue
Oct 6, 2022
JulianDomingo
pushed a commit
that referenced
this issue
Oct 7, 2022
JulianDomingo
pushed a commit
that referenced
this issue
Oct 7, 2022
JulianDomingo
pushed a commit
that referenced
this issue
Oct 7, 2022
🤖 I have created a release *beep* *boop* --- ## [3.2.13](v3.2.12...v3.2.13) (2022-10-07) ### Bug Fixes * allow build without text ([#4506](#4506)) ([5f3afd4](5f3afd4)) * allow the playback on platforms when low latency APIs are not supported ([#4485](#4485)) ([0239aa5](0239aa5)) * check for negative rows before moving ([#4510](#4510)) ([12e3305](12e3305)), closes [#4508](#4508) * Filter unsupported H.264 streams in Xbox ([#4493](#4493)) ([ea02766](ea02766)) * Fix hang when seeking to the last segment ([#4537](#4537)) ([951aaea](951aaea)) * Respect existing app usage of Cast SDK ([#4523](#4523)) ([da5fd15](da5fd15)), closes [#4521](#4521) * **ttml:** Default TTML background color to transparent if unspecified ([#4496](#4496)) ([0c6ad6d](0c6ad6d)), closes [#4468](#4468) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
JulianDomingo
pushed a commit
that referenced
this issue
Oct 7, 2022
🤖 I have created a release *beep* *boop* --- ## [3.3.11](v3.3.10...v3.3.11) (2022-10-07) ### Bug Fixes * allow build without text ([#4506](#4506)) ([5014c1d](5014c1d)) * allow the playback on platforms when low latency APIs are not supported ([#4485](#4485)) ([c0fc0b4](c0fc0b4)) * check for negative rows before moving ([#4510](#4510)) ([359b63e](359b63e)), closes [#4508](#4508) * Filter unsupported H.264 streams in Xbox ([#4493](#4493)) ([21ee94f](21ee94f)) * Fix hang when seeking to the last segment ([#4537](#4537)) ([2868e12](2868e12)) * Respect existing app usage of Cast SDK ([#4523](#4523)) ([d2258d6](d2258d6)), closes [#4521](#4521) * **ttml:** Default TTML background color to transparent if unspecified ([#4496](#4496)) ([862ee42](862ee42)), closes [#4468](#4468) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
JulianDomingo
pushed a commit
that referenced
this issue
Oct 7, 2022
🤖 I have created a release *beep* *boop* --- ## [4.1.5](v4.1.4...v4.1.5) (2022-10-07) ### Bug Fixes * allow build without text ([#4506](#4506)) ([1db6265](1db6265)) * allow the playback on platforms when low latency APIs are not supported ([#4485](#4485)) ([55d1390](55d1390)) * check for negative rows before moving ([#4510](#4510)) ([31abae3](31abae3)), closes [#4508](#4508) * Filter unsupported H.264 streams in Xbox ([#4493](#4493)) ([1ecede6](1ecede6)) * Fix choppy HLS startup ([#4553](#4553)) ([1675bff](1675bff)), closes [#4516](#4516) * Fix errors with TS segments on Chromecast ([#4543](#4543)) ([15a1c60](15a1c60)) * Fix hang when seeking to the last segment ([#4537](#4537)) ([72a119d](72a119d)) * Fix HLS dynamic to static transition ([932d37c](932d37c)) * Fix HLS dynamic to static transition ([#4483](#4483)) ([932d37c](932d37c)), closes [#4431](#4431) * Fix in-band key rotation on Xbox One ([#4478](#4478)) ([5a8f09c](5a8f09c)), closes [#4401](#4401) * Respect existing app usage of Cast SDK ([#4523](#4523)) ([9c3a494](9c3a494)), closes [#4521](#4521) * **ttml:** Default TTML background color to transparent if unspecified ([#4496](#4496)) ([16da1e7](16da1e7)), closes [#4468](#4468) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
JulianDomingo
pushed a commit
that referenced
this issue
Oct 7, 2022
🤖 I have created a release *beep* *boop* --- ## [4.2.2](v4.2.1...v4.2.2) (2022-10-07) ### Bug Fixes * allow build without text ([#4506](#4506)) ([7e93720](7e93720)) * allow the playback on platforms when low latency APIs are not supported ([#4485](#4485)) ([cf8c857](cf8c857)) * check for negative rows before moving ([#4510](#4510)) ([23f39d7](23f39d7)), closes [#4508](#4508) * Filter unsupported H.264 streams in Xbox ([#4493](#4493)) ([914a08a](914a08a)) * Fix choppy HLS startup ([#4553](#4553)) ([950ce69](950ce69)), closes [#4516](#4516) * Fix errors with TS segments on Chromecast ([#4543](#4543)) ([8204db6](8204db6)) * Fix hang when seeking to the last segment ([#4537](#4537)) ([3d6c768](3d6c768)) * Fix HLS dynamic to static transition ([d9ecbf3](d9ecbf3)) * Fix HLS dynamic to static transition ([#4483](#4483)) ([d9ecbf3](d9ecbf3)), closes [#4431](#4431) * Fix in-band key rotation on Xbox One ([#4478](#4478)) ([bc0a588](bc0a588)), closes [#4401](#4401) * Missing AES-128 key of last HLS segment ([#4519](#4519)) ([2c2677f](2c2677f)), closes [#4517](#4517) * Respect existing app usage of Cast SDK ([#4523](#4523)) ([3db2568](3db2568)), closes [#4521](#4521) * **ttml:** Default TTML background color to transparent if unspecified ([#4496](#4496)) ([0b5c985](0b5c985)), closes [#4468](#4468) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
the
status: archived
Archived and locked; will not be updated
label
Dec 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
priority: P2
Smaller impact or easy workaround
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
type: enhancement
New feature or request
Have you read the FAQ and checked for duplicate open issues?
Yup. No open duplicates. Next of kin: #3167
Is your feature request related to a problem? Please describe.
In our project we use -- and consequently load -- Google Cast framework. Hence, we register a callback in window.__onGCastApiAvailable . Then, when we initialize shaka.cast.CastProxy it gives up, throwing error 8000 ('CAST_API_UNAVAILABLE').
Describe the solution you'd like
The shaka.CastProxy could save any pre-existing window.__onGCastApiAvailable before registering its own callback. Then, when the framework becomes available, it could execute its own business logic, and restore __onGCastApiAvailable and call it (with the appropriate argument).
Describe alternatives you've considered
The only alternative I see is initializing shaka.cast.CastProxy before loading Google Cast framework, as our code already does play nicely with pre-existing window.__onGCastApiAvailable . That, however, would imply a restructuring from the ground up. Currently a specific "media endpoint" (e.g. Shaka endpoint) is only summoned into existence when needed for playing a specific media format (e.g. MPEG-Dash).
Additional context
A PR of the proposed solution will be provided.
The text was updated successfully, but these errors were encountered: