Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/mandrill subaccount #628

Closed

Conversation

acgray
Copy link

@acgray acgray commented Aug 14, 2017

The subaccount property is only currently included in the message_sent schema but appears in all Mandrill-sent events. This currently causes these events to fail enrichment.

Adam Gray added 2 commits August 12, 2017 20:32
The subaccount property is only currently included in the message_sent schema but appears in all Mandrill-sent events.  This currently causes these events to fail enrichment.
@snowplowcla
Copy link

@acgray has signed the Software Grant and Corporate Contributor License Agreement

@BenFradet BenFradet self-requested a review September 13, 2017 14:34
@alexanderdean alexanderdean requested review from knservis and removed request for BenFradet November 2, 2017 21:18
@BenFradet
Copy link
Contributor

This needs to be in the same release than #745

@BenFradet BenFradet requested review from chuwy and BenFradet and removed request for knservis April 3, 2018 16:06
@alexanderdean alexanderdean modified the milestones: Release 90, Release 89 Apr 3, 2018
@alexanderdean
Copy link
Member

No problem, scheduled. Please review!

Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: message_rejected also already contains subaccount, over to @chuwy

Copy link
Contributor

@chuwy chuwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BenFradet
Copy link
Contributor

incorporated into #753, thanks!

@BenFradet BenFradet closed this Apr 6, 2018
@alexanderdean
Copy link
Member

Many thanks @acgray !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants