-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/mandrill subaccount #628
Conversation
The subaccount property is only currently included in the message_sent schema but appears in all Mandrill-sent events. This currently causes these events to fail enrichment.
@acgray has signed the Software Grant and Corporate Contributor License Agreement |
This needs to be in the same release than #745 |
No problem, scheduled. Please review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NB: message_rejected also already contains subaccount, over to @chuwy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
incorporated into #753, thanks! |
Many thanks @acgray ! |
The subaccount property is only currently included in the message_sent schema but appears in all Mandrill-sent events. This currently causes these events to fail enrichment.