Release 89 #753
Release 89 #753
Conversation
BenFradet
force-pushed
the
release/r89
branch
3 times, most recently
from
18a31de to
dc07fd0
Compare
|
@alexanderdean this is good to go 👍 We had to manually edit the ddl and jsonpaths since they weren't igluctl-compatible to begin with. |
There was a problem hiding this comment.
Not sure why this was approved - unfortunately this release can't go out in this form: the reason is the JSON Paths modifications for the Mandrill 1-0-1s (message_bounced_1.json etc).
If this is released and these JSON Paths deployed, then the Redshift load of Mandrill data will suddenly break for existing Snowplow users.
The solution is to migrate just these JSON Path and Redshift table changes into a new branch, create corresponding ticket(s) and assign to the Blocked Redshift artifacts milestone.
The rest of the PR can go out - if you make the change I will give it a green tick.
|
Hey, @alexanderdean, we considered the fact about breaking JSONPaths (sorry, had to make conversation public). The reason why I approved this is because as far as I understand the problem - there's simply nothing to break: all data for |
|
Thanks @chuwy - that makes sense. @yalisassoon is that your understanding of the current Mandrill situation - that the webhook is not working for customers in its current form? |
|
Removed ddl and jsonpaths which have been extracted into #763 |
CHANGELOG
Outdated
| @@ -1,3 +1,14 @@ | |||
| Release 89 (2018-04-06) | |||
There was a problem hiding this comment.
Date needs changing to today
| "properties": { | ||
| "vendor": { | ||
| "type": "string", | ||
| "maxLength": 256 |
There was a problem hiding this comment.
Whitespace is all messed up in this file (see 6 more instances below).
There was a problem hiding this comment.
mix-indent ftw...
|
@alexanderdean fixed 👍 |
No description provided.