Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add com.snowplowanalytics.snowplow/ip_lookups/jsonschema/2-0-0 #745

Closed
wants to merge 1 commit into from
Closed

Add com.snowplowanalytics.snowplow/ip_lookups/jsonschema/2-0-0 #745

wants to merge 1 commit into from

Conversation

BenFradet
Copy link
Contributor

No description provided.

chuwy
chuwy approved these changes Apr 2, 2018
View reviewed changes
Copy link
Contributor

@chuwy chuwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Also, adding maxLengths to strings can be useful (e.g. 128 or 256 look like a reasonable upper bound for vendor and name).

schemas/com.snowplowanalytics.snowplow/ip_lookups/jsonschema/2-0-0 Outdated
"enum": ["GeoIP2-ISP.mmdb"]
},
"uri": {
"type": "string"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be format: uri.

schemas/com.snowplowanalytics.snowplow/ip_lookups/jsonschema/2-0-0 Outdated
"enum": ["GeoLite2-City.mmdb", "GeoIP2-City.mmdb"]
},
"uri": {
"type": "string"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be format: uri.

@BenFradet BenFradet mentioned this pull request Apr 3, 2018
Closed
@alexanderdean alexanderdean added this to the Release 89 milestone Apr 3, 2018
@alexanderdean
Copy link
Member

Scheduled.

alexanderdean
alexanderdean approved these changes Apr 5, 2018
View reviewed changes
Copy link
Member

@alexanderdean alexanderdean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed diff 1-0-0 2-0-0 and it looks fine to me. We are forcing the new .mmdb files in the 2-0-0, GeoIPOrg.dat seems to have been end-of-lifed and GeoIP2-Connection-Type.mmdb has replaced the two NetSpeed* databases. Approved.

@alexanderdean
Copy link
Member

@BenFradet - please put together the complete PR for R89. Ping @chuwy if anything is unclear.

@BenFradet
Copy link
Contributor Author

incorporated into #753

@BenFradet BenFradet closed this Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuwy chuwy chuwy approved these changes

@alexanderdean alexanderdean alexanderdean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 89
Development

Successfully merging this pull request may close these issues.
3 participants
@BenFradet @alexanderdean @chuwy