Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore previous priorityIsSeverity value after retry #197

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

fix: restore previous priorityIsSeverity value after retry #197

wants to merge 5 commits into from

Conversation

rback123
Copy link

  • Tests written and linted ℹ︎
  • Documentation written ℹ︎
  • Commit history is tidy ℹ︎

What this does

Explain why this PR exists

This PR fixes an issue where the priorityIsSeverity value is modified for a retry attempt but is never restored to the previous value after the retry. Without this fix, any subsequent vulnForJira processed (for loop on line 249) may have an incorrect Jira priority value.

Notes for the reviewer

Replicate by this scenario:

  1. Use --priorityIsSeverity=true
  2. Attempt to create multiple Jira tickets of varying priority
  3. Experience an error during Jira creation
    1. Example - the Snyk severity maps to a Jira priority that doesn't exist
  4. Check priority of tickets processed and created after the error is encountered

More information

  • n/a

Screenshots

  • n/a

lili2311 and others added 5 commits December 2, 2022 18:35
@lili2311 @thavelock
minor: Adding new flag: canAutoPR (snyk-tech-services#187)
dc5f5b4 
Thi is to address snyk-tech-services#182

Co-authored-by: Troy Havelock <[email protected]>
@lili2311 @vallieres
minor: Added DueDate support for creating Jira (snyk-tech-services#185)
3d877de 
Added the optional flag for the due date built-in flag.
Updated README with instructions

Co-authored-by: Alexandre Vallières-Lagacé <[email protected]>
@jlourenc
fix: align urls with the recommended domains and paths (snyk-tech-ser…
1bd4d48 
…vices#192)

Switch from:
- `snyk.io/api` to `api.snyk.io`
- `api.snyk.io/api` to `api.snyk.io`
- `snyk.io/vuln` to `security.snyk.io/vuln`
- `api.snyk.io/v3` to `api.snyk.io/rest`
@aarlaud
fix: use public utility container for github releasing tool (snyk-tec…
c3dca5d 
…h-services#194)
@rback123
fix: restore previous priorityIsSeverity value after retry
b71b394
@rback123 rback123 requested a review from a team as a code owner May 11, 2023 23:31
@aarlaud
Copy link
Contributor

aarlaud commented Oct 29, 2024

horribly behind, apologies. please rebase off develop to get this in. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rback123 @aarlaud @lili2311 @jlourenc