fix(iOS): FullWindowOverlay layout height #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
reviewed
Oct 22, 2024
kkafar
approved these changes
Oct 22, 2024
kkafar
pushed a commit
that referenced
this pull request
Oct 25, 2024
## Description This PR intents to fix `FullWindowOverlay`s height issue. The component is given wrong frame size during layout because of it's placement in the react tree. Although in the iOS view hierarchy it is displayed independently its height is still reduced by the height of the header. Correct frame can be achieved by utilising `useWindowDimensions` hook and forcing correct width and height on the JS side. Fixes #1247 ## Changes - modified `Test1096` repro ## Screenshots / GIFs ### Before  ### After  ## Test code and steps to reproduce - use `Test1096` repro ## Checklist - [x] Included code example that can be used to test this change - [x] Ensured that CI passes (cherry picked from commit cf31492)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intents to fix
FullWindowOverlays height issue.The component is given wrong frame size during layout because of it's placement in the react tree. Although in the iOS view hierarchy it is displayed independently its height is still reduced by the height of the header.
Correct frame can be achieved by utilising
useWindowDimensionshook and forcing correct width and height on the JS side.Fixes #1247
Changes
Test1096reproScreenshots / GIFs
Before
After
Test code and steps to reproduce
Test1096reproChecklist