Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown shuttle event changes #28094

Closed

Conversation

Flareguy
Copy link
Contributor

@Flareguy Flareguy commented May 17, 2024

About the PR

Makes major adjustments to many parts of the unknown shuttle event.
Fixes #27972.

The Travelling Chef role is now a "neutral" antagonist, like the closet skeleton.
The cargo shuttle & pod events have been replaced with a ship pilot role. This role is also a neutral antagonist.
The syndicate evac pod event has been retooled in to the Syndicate Raider event. Like the others, they are neutral antagonists.

The clown shuttle has been removed since #28053 is going to remove it anyways. It apparently wasn't very conductive to roleplay, even on MRP.

I understand that this may seem too far for the freeze, but the approaching shuttle event was merged a day before the freeze, so there wasn't really any chance to fix it. The changes here should not require too much tuning other then just reducing the event weights, anyways.

Why / Balance

Even ignoring the massive admin issues these roles cause (look at the linked issue,) of the unknown shuttles (with the exception of the travelling chef) are just conceptually very odd ghost roles. Almost all of these collectively suffer from being nearly the same as crew roles, and having little directive or agency to influence the round due to their lack of objectives & non-antag status.

Take the cargo shuttle for instance. There is no goal or driving factor other then "you are a cargo tech." It is basically just a random cargo tech respawn, except you probably didn't even come in with a plan like you would if you would have spawned as a cargo tech roundstart. It is likely that anyone picking this role will eventually SSD due to not knowing what to do / getting bored, or just not pick it due to knowing they're not going to have fun.

By making all of these roles able to have full agency to do whatever they want, they should be able to drive the round in whatever fashion they please, and eliminate the admin issues completely.

The reduced amount of shuttle events (6 > 3) should make the spawn rates for these less overwhelming, though I obviously have no idea if they are still overwhelming.

Media

Content Client_LvG6tZZRpa
Poor screenshot of the one new ship (the shuttle pilot shuttle.)

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
🆑

  • tweak: All unknown shuttle ghost roles are now "neutral" like closet skeletons, and have no allegiance.
  • tweak: Replaced the cargo tech & evacuation pod events with a new event: the shuttle pilot.

@Flareguy Flareguy requested a review from DrSmugleaf as a code owner May 17, 2024 11:55
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label May 17, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted Changes: No C# Changes: Requires no C# knowledge to review or fix this item. and removed S: Needs Review Status: Requires additional reviews before being fully accepted S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted labels May 17, 2024
@Dutch-VanDerLinde
Copy link
Contributor

Dutch-VanDerLinde commented May 17, 2024

Changelog broken no 🆑

@Djungelskog2
Copy link

ok but itd be really weird if they didnt have to follow escalation

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label May 17, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Hmeister-real
Copy link
Contributor

evac pod event was cool, i liked it adding another head to the round and it had some interesting rp. sad to see it getting removed

@Djungelskog2
Copy link

more station friendly personnel ghost roles would be fun
My suggestions is keeping the cargo and travelling chefs the same but increasing their odds of being traitors drastically, ive never found issue with "Just being crew", although you may argue that the chef isnt part station or its crew he should act as a visitor at the very least. I like the reworking of the regular evac pod into a neutral pilot, but they should also follow escalation. Lastly the syndi raider event, im not sure how it works but im guessing its just an even more overwhelming sleeper agent event in functionality which is a pretty large issue in my opinion, Theres 100% an issue with the syndi shuttle at the moment but there are more creative and stand-out antag shuttle ideas that could be used, a ship overtaken by some anomaly, a skeleton pirate who has large amounts of loot from plundering another station and is an OUTRIGHT antag with the goal of stealing shit or a neutral zookeeper carrying large amounts of feral tarantulas. The syndi raid seems like its based on loads of already existing midrounds without adding much unique experience or round variety other than more for sec to handle, it could be done in a way to promote RP, funny unique scenarios or having small standalone interventions and interactions with the new shuttles rather than just "more syndis"

@Djungelskog2
Copy link

Comparing every neutral antag to the skeleton is a really bad idea because they are free to do anything they like, complete NRP and murderboning and sabotage. They are a primordial force of chaos and a normal humanoid being shouldnt be on that standard unless you are outright an antagonist. More Neutral roles are a fun concept but by comparing them all to a skeleton all it boils down to is "NRP, Crime, Murder" which is what makes the skeleton scary and unique and more roles having those rules will just lead to less fun of the crews end

@thebadman4662
Copy link

At least syndie crew gets to act like enemies they are now.

@beck-thompson
Copy link
Contributor

beck-thompson commented May 17, 2024

The reduced amount of shuttle events (6 > 3) should make the spawn rates for these less overwhelming, though I obviously have no idea if they are still overwhelming.

Why would reducing the total number of events make the spawn rates decrease?

(Oh also I love the shuttle pilot idea)

@Savsj
Copy link

Savsj commented May 17, 2024

Why are we just removing an amazing ghost role for RP in favor of more of the same antag we get constantly anyway? Like the roles from the shuttles are already station neutral, why are making them antags when tbh theyre better as non antags? This feels like a notable downgrade for RP potential.

@IProduceWidgets
Copy link
Contributor

IProduceWidgets commented May 17, 2024

I have some reservations about making them all neutral- I think we should have some friendly ghost roles.

My bigger issue though is I think this is a bandaid for a lack of ways to convey neutral or friendly status/goals to players. We desperately need a way to put objectives or at least indicators in the C character menu. As well as a way to convey this to admins. Neutral roles don't even show up to admins as special but are antags in all but name.

A side note, and this could be another PR, is it could be worthwhile to just make prototype role spawners for shuttle events with differing goals / alignment. Those could be useful for mapping and admemes. We could have versions of these events where the crew that shows up is hostile when usually they are friendly.

@Killerqu00
Copy link
Contributor

Please do not make them neutral antagonists. Most ghost roles are already not enjoyable due to being extremely disposable, for example, rat kings being killed on sight without any interactions whatsoever. These shuttle roles have a chance to actually be interesting for roleplay if done right, and this is not what will improve them.

@Cojoke-dot
Copy link
Contributor

Making them neutral gives a much more interesting interaction with sec and command. Can these people from space be trusted? Can I allow this syndicate agent to walk free or do I just perma them? Much more interesting than "huh, some people in weird clothing, go get a job or something, I don't care"

@Savsj
Copy link

Savsj commented May 17, 2024

Making them neutral is just going to make them valid, they are already an interesting interaction with command and crew by saying "the people with cool loot i want are free game because they are not crew so i am allowed to butcher them in a crowded hallway" i believe giving them a chance to be antaggonists and actual syndies like with an uplink would be neat

@Cojoke-dot
Copy link
Contributor

Making them neutral is just going to make them valid, they are already an interesting interaction with command and crew by saying "the people with cool loot i want are free game because they are not crew so i am allowed to butcher them in a crowded hallway" i believe giving them a chance to be antaggonists and actual syndies like with an uplink would be neat

This is where the "don't be a dick rule" comes in. Either way sec is not going to like someone just murdering a non-skeleton and it's not hard to get in the manifest.

@Killerqu00
Copy link
Contributor

Making them neutral is just going to make them valid, they are already an interesting interaction with command and crew by saying "the people with cool loot i want are free game because they are not crew so i am allowed to butcher them in a crowded hallway" i believe giving them a chance to be antaggonists and actual syndies like with an uplink would be neat

This is where the "don't be a dick rule" comes in. Either way sec is not going to like someone just murdering a non-skeleton and it's not hard to get in the manifest.

It does not apply to neutral antags, you can kill them on the spot without consequences

@Cojoke-dot
Copy link
Contributor

Sure, but does that happen... uh... almost ever? I've been skeleton tons of times and have not once had that happen. The only time I've seen that happen is in the Armok video and that's a unique situation.

@SlamBamActionman
Copy link
Member

SlamBamActionman commented May 17, 2024

I see a missed opportunity to make the Cargo techs a neutral antag affiliated with a non-NT company (e.g. DonkCo).

Sure, but does that happen... uh... almost ever? I've been skeleton tons of times and have not once had that happen. The only time I've seen that happen is in the Armok video and that's a unique situation.

This def happens. Not often, as people generally see skeletons as a fun role to have on the station, but I've seen it happen and even enforced Cap's orders as HoS to KoS supposedly friendly skeletons

# Conflicts:
#	Resources/Prototypes/Entities/Mobs/Player/humanoid.yml
#	Resources/migration.yml
@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label May 18, 2024
@Savsj
Copy link

Savsj commented May 18, 2024

Sure, but does that happen... uh... almost ever? I've been skeleton tons of times and have not once had that happen. The only time I've seen that happen is in the Armok video and that's a unique situation.

I have had that in 4 of 5 skeleton rounds ive played and all but a single round i have played as the ratking which is what we are proposing to turn these ghost roles into, if there was a middle between the two where they have the option of some antaggonism, but cannot be killed on sight like these roles can be it would be better.

I see a missed opportunity to make the Cargo techs a neutral antag affiliated with a non-NT company (e.g. DonkCo).

This could be a really fun and interactive spawn for the cargo techs ghost role if it had a chance of spawning as like a representative of a neutral entity with different stuff on their shuttle and different outfits from time to time.

@thebadman4662
Copy link

But they can't be killed on sight, aside from syndies, which are obviously enemies of NT on top of not having crew rights.

Other shuttle crews should get IDs, which they already got AFAIK but those are not visitor ones, rather station job probably so you should still direct them to HoP for icon change if they are not joining crew but just visit.

Security simply have no reason to KOS them if they are not a threat, we can't exactly compare chef to space monster abomination, now, can we?

@SlamBamActionman
Copy link
Member

But they can't be killed on sight, aside from syndies, which are obviously enemies of NT on top of not having crew rights.

Other shuttle crews should get IDs, which they already got AFAIK but those are not visitor ones, rather station job probably so you should still direct them to HoP for icon change if they are not joining crew but just visit.

Security simply have no reason to KOS them if they are not a threat, we can't exactly compare chef to space monster abomination, now, can we?

I am more concerned with how according to the written rules these roles are differentiated from skeletons than what makes sense for them in-universe. We all agree that chefs should not be comparable to space monster abominations and should be treated with more hospitality from crew, the issue is if rules-wise they are.

@@ -590,6 +590,8 @@
- type: GhostTakeoverAvailable
- type: Cluwne

<<<<<<< HEAD
=======
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you probably didn't intend to leave this in here

@thebadman4662
Copy link

But they can't be killed on sight, aside from syndies, which are obviously enemies of NT on top of not having crew rights.
Other shuttle crews should get IDs, which they already got AFAIK but those are not visitor ones, rather station job probably so you should still direct them to HoP for icon change if they are not joining crew but just visit.
Security simply have no reason to KOS them if they are not a threat, we can't exactly compare chef to space monster abomination, now, can we?

I am more concerned with how according to the written rules these roles are differentiated from skeletons than what makes sense for them in-universe. We all agree that chefs should not be comparable to space monster abominations and should be treated with more hospitality from crew, the issue is if rules-wise they are.

They are neutral so they can fight back and even kill if they want to, should they choose to do it. Of course it also gives them option to start something that could escalate into skeleton murderbone of sorts so admins would need to create yet another tier/type of antags if space chefs going postal should prove to be too much for them, which probably won't be a problem considering how skeletons fare.

@Djungelskog2
Copy link

But they can't be killed on sight, aside from syndies, which are obviously enemies of NT on top of not having crew rights.
Other shuttle crews should get IDs, which they already got AFAIK but those are not visitor ones, rather station job probably so you should still direct them to HoP for icon change if they are not joining crew but just visit.
Security simply have no reason to KOS them if they are not a threat, we can't exactly compare chef to space monster abomination, now, can we?

I am more concerned with how according to the written rules these roles are differentiated from skeletons than what makes sense for them in-universe. We all agree that chefs should not be comparable to space monster abominations and should be treated with more hospitality from crew, the issue is if rules-wise they are.

They are neutral so they can fight back and even kill if they want to, should they choose to do it. Of course it also gives them option to start something that could escalate into skeleton murderbone of sorts so admins would need to create yet another tier/type of antags if space chefs going postal should prove to be too much for them, which probably won't be a problem considering how skeletons fare.

the point is that we dont want or need another skeleton type role, the only reason skeletons arent too much of a pain is because A: they are a unique species, B: They dont have a role or identifier that would automatically make them crew or make people think they are crew and C: Skeletons are expected to behave however they want

@PotatOverlord
Copy link

There is no reason for the traveling chefs to be an antagonist of any kind; They are just chefs going around and cooking cool stuff. Allowing them to be neutral antags will invariably cause people to use them as an excuse to murderbone and poison the crew (Also an easy way to metagrudge someone). They can already defend themselves since they are under the same rules as crew, which allows self defense. Keeping them as friendly ghost roles will prevent NRP situations and keep the randomness and chaotic flair that the shuttle roles already bring. The syndicate shuttle being reworked was needed, but not in this way, for similar reasons, but I'll let other people argue for that because I'm lazy. Also the shuttle they use is an evac pod; it has no reverse thrust so maybe fix that if this goes through.

@K-Dynamic
Copy link
Contributor

Yeah there should be some clarification on what type of neutral

A skeleton is definitely their own act of nature and can be as such, a travelling chef that's making food on a ship that they've probably got a mortgage on... yeah they're neutral to NT but shouldn't be able to roleplay destroying everyone

@Savsj
Copy link

Savsj commented May 19, 2024

I also think simply changing the syndie survivors to diet nukies is going to be an swift way to ruin a ghost role thats got a lot of good RP.

@GroggleG
Copy link

I also think simply changing the syndie survivors to diet nukies is going to be an swift way to ruin a ghost role thats got a lot of good RP.

Most of the "good RP" ive seen so far is getting gunned down by sec (happened twice to me myself), I dont think something that is syndicate branded should be AT ALL crew rules NOR do I think it should be a true neutral. Though diet nukies is no fun at all. I know people dont like canning this stuff but I didnt like the cadets at all tbh.

@Savsj
Copy link

Savsj commented May 19, 2024

I also think simply changing the syndie survivors to diet nukies is going to be an swift way to ruin a ghost role thats got a lot of good RP.

Most of the "good RP" ive seen so far is getting gunned down by sec (happened twice to me myself), I dont think something that is syndicate branded should be AT ALL crew rules NOR do I think it should be a true neutral. Though diet nukies is no fun at all. I know people dont like canning this stuff but I didnt like the cadets at all tbh.

and thats a genuine problem of it being people not being properly informed of whats actually happening and what the role actually is, i have personally never seen the syndies gunned down but i play on mander. So YMMV but i think ultimately what this needs is a clarification vs a change.

@Dragonjspider
Copy link

In my opinion, the only shuttle that should have a neutral antag status is the syndie one. But even that has to have more restrictions than skeletons, since it doesn't seem reasonable for them to murder anyone or steal the armory. Like, for instance, they don't need to do anything antag related, but if a syndie decides to ask for help with objectives, I feel like they should have the right to accept them.

In fact, if you ask me, the skeleton is a chaotic neutral antag, as they have no goals to speak of, they do what would be the most entertaining for them at the moment.

The biggest issue with the idea of making any of them neutral antags is the point that without an objective, you don't have any goals, which makes doing antag activities more appealing to do. I can already see a visiting chef deciding to kill a crewmember and making human food out of them if that happened.

Not to mention, like IProduceWidgets said, an admin wouldn't have an easy way of identifying them as a neutral antag, since they're a human just like any other crewmember. Asking them to remember the names of up to 3 different people, all being neutral antags is too much, they have a lot more to pay attention to already...

By making all of these roles able to have full agency to do whatever they want, they should be able to drive the round in whatever fashion they please, and eliminate the admin issues completely.

This wouldn't remove any issues admins have with the roles, it gives the roles more freedom to do things, which would muddy what's already a difficult role to gauge what the limit for them is. It goes from "well they just killed a guy, so that's a boink" to "well they just killed a guy, now I gotta double check whether or not they're doing it IC or if it's murderbone"

The only way I can see this working at all is some kind of system that allowed you, as a neutral antag, to write a goal up, and send a request to something admins can see. So an admin might see their objective, and choose to allow it or not. But this gets into a whole other issue and is way out of scope...

@GroggleG
Copy link

In my opinion, the only shuttle that should have a neutral antag status is the syndie one. But even that has to have more restrictions than skeletons, since it doesn't seem reasonable for them to murder anyone or steal the armory. Like, for instance, they don't need to do anything antag related, but if a syndie decides to ask for help with objectives, I feel like they should have the right to accept them.

In fact, if you ask me, the skeleton is a chaotic neutral antag, as they have no goals to speak of, they do what would be the most entertaining for them at the moment.

The biggest issue with the idea of making any of them neutral antags is the point that without an objective, you don't have any goals, which makes doing antag activities more appealing to do. I can already see a visiting chef deciding to kill a crewmember and making human food out of them if that happened.

Not to mention, like IProduceWidgets said, an admin wouldn't have an easy way of identifying them as a neutral antag, since they're a human just like any other crewmember. Asking them to remember the names of up to 3 different people, all being neutral antags is too much, they have a lot more to pay attention to already...

By making all of these roles able to have full agency to do whatever they want, they should be able to drive the round in whatever fashion they please, and eliminate the admin issues completely.

This wouldn't remove any issues admins have with the roles, it gives the roles more freedom to do things, which would muddy what's already a difficult role to gauge what the limit for them is. It goes from "well they just killed a guy, so that's a boink" to "well they just killed a guy, now I gotta double check whether or not they're doing it IC or if it's murderbone"

The only way I can see this working at all is some kind of system that allowed you, as a neutral antag, to write a goal up, and send a request to something admins can see. So an admin might see their objective, and choose to allow it or not. But this gets into a whole other issue and is way out of scope...

I feel like that most of the issues with the whole syndicadets would be completely sidestepped if we had listening post made well, giving a more concrete way of identification and an actual goal. I just dont like the way that the syndicadets are implemented and should be given more time in the oven.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label May 20, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@XxSWAG-MASTER-OVERLORDxX

I think with the clown shuttle, if you replaced the clown spiders with honk bots it would be a lot better

@TheShuEd TheShuEd closed this May 22, 2024
@TheShuEd
Copy link
Member

map errors + merg conflict
i recreate PR later

@TheShuEd
Copy link
Member

sorry wrong PR closed

@TheShuEd TheShuEd reopened this May 27, 2024
@Brandon-Huu
Copy link
Contributor

I vote to leave in clown shuttle.

@Flareguy
Copy link
Contributor Author

Flareguy commented Jun 1, 2024

Don't feel like working on this much lately + branch is cooked. I might get to this myself but would really appreciate if someone else got to the PR.

@Flareguy Flareguy closed this Jun 1, 2024
@neutrino-laser neutrino-laser mentioned this pull request Jun 8, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Unknown shuttles are a admin nightmare