Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

didkit v0.4.0 #269

Merged
merged 6 commits into from
Mar 4, 2022
Merged

didkit v0.4.0 #269

merged 6 commits into from
Mar 4, 2022

Conversation

clehner
Copy link
Contributor

@clehner clehner commented Mar 3, 2022 •
edited
Loading

Updated to use ssi v0.4 (spruceid/ssi#401).

Changelog updated for changes since v0.3.0.

Updates for new ssi DID method crate versions (spruceid/ssi#403) should not be needed, since the crate versions will still be matched (They are all v0.1.x). default-features=no is set for the DID method crates, because of spruceid/ssi#402.

Updated crate versions for publishing:

  • didkit v0.4.0
  • didkit-cli v0.2.0
  • didkit-http v0.2.0

@clehner clehner marked this pull request as draft March 3, 2022 14:23
@clehner clehner force-pushed the release/0.4 branch 2 times, most recently from 34561e6 to fe15a22 Compare March 3, 2022 15:03
@clehner clehner marked this pull request as ready for review March 3, 2022 15:04
@clehner
Copy link
Contributor Author

clehner commented Mar 3, 2022 •
edited
Loading

Blocked by #270
Using Rust nightly to work around #270.

@clehner clehner marked this pull request as draft March 3, 2022 17:24
@clehner clehner marked this pull request as ready for review March 3, 2022 17:36
@clehner clehner requested a review from sbihel March 3, 2022 18:44
@clehner clehner mentioned this pull request Mar 3, 2022
Merged
8 tasks
@sbihel
Copy link
Member

sbihel commented Mar 4, 2022

Blocked by #270 Using Rust nightly to work around #270.

Are you sure it's a Rust problem? The build was stopped by a SIGKILL

@clehner
Copy link
Contributor Author

clehner commented Mar 4, 2022

Are you sure it's a Rust problem? The build was stopped by a SIGKILL

Not sure, but given the memory use pattern I think the SIGKILL is from out of memory - process killed by the kernel.

@sbihel
Copy link
Member

sbihel commented Mar 4, 2022

Ah? Could it be because 1.59 has incremental compilation disabled?

@clehner
Copy link
Contributor Author

clehner commented Mar 4, 2022

I don't know... setting CARGO_INCREMENTAL=1 doesn't seem to help.

@clehner
Copy link
Contributor Author

clehner commented Mar 4, 2022

Build with cargo 1.58.0 succeeds. Amending PR to use 1.58.0 instead of nightly...

@clehner clehner marked this pull request as draft March 4, 2022 17:54
@clehner clehner marked this pull request as ready for review March 4, 2022 17:58
@clehner clehner mentioned this pull request Mar 4, 2022
Closed
@clehner
Copy link
Contributor Author

clehner commented Mar 4, 2022

Published:

@clehner clehner merged commit 1786ba4 into main Mar 4, 2022
@clehner clehner deleted the release/0.4 branch March 4, 2022 20:30
This was referenced Mar 4, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbihel sbihel Awaiting requested review from sbihel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clehner @sbihel