Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssi v0.4.0 #401

Merged
merged 2 commits into from
Mar 2, 2022
Merged

ssi v0.4.0 #401

merged 2 commits into from
Mar 2, 2022

Conversation

clehner
Copy link
Contributor

@clehner clehner commented Mar 2, 2022 •
edited
Loading

Tag ssi v0.4.0 for publishing to crates.io.

DID method crates to be updated after ssi is published.

Breaking changes

@clehner clehner marked this pull request as draft March 2, 2022 17:07
@clehner clehner marked this pull request as ready for review March 2, 2022 17:14
@clehner clehner requested a review from sbihel March 2, 2022 17:21
@sbihel
Copy link
Member

sbihel commented Mar 2, 2022

I think it's missing the update to Cargo.toml?

@clehner clehner marked this pull request as draft March 2, 2022 17:30
@clehner
Copy link
Contributor Author

clehner commented Mar 2, 2022 •
edited
Loading

missing the update to Cargo.toml

Fixed, thanks. Maybe the other crates can then be updated here as well...
Edit: or separately.

@clehner clehner marked this pull request as ready for review March 2, 2022 17:32
@clehner clehner requested a review from sbihel March 2, 2022 17:32
@clehner clehner marked this pull request as draft March 2, 2022 17:39
@clehner clehner marked this pull request as ready for review March 2, 2022 17:40
@sbihel
Copy link
Member

sbihel commented Mar 2, 2022

Probably should update the dependencies at the same time as you update their own versions

@clehner
Copy link
Contributor Author

clehner commented Mar 2, 2022

Probably should update the dependencies at the same time as you update their own versions

They have to be updated to depend on ssi v0.4, since v0.3 will no longer be in the workspace:
https://github.com/spruceid/ssi/runs/5395669334?check_suite_focus=true#step:4:11
That is done in 4d6ffc0. (I forgot about this before; it's been a while since making a release)

4d6ffc0 passed CI, so the workspace still builds successfully.

did-tz and did-webkey will need a version bump for publishing. The other DID method crates need additional changes to be able to build by default on their own (#402),

sbihel
sbihel approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@sbihel sbihel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Using both version and path is tricky 😕

@clehner clehner merged commit 4d6ffc0 into main Mar 2, 2022
@clehner clehner deleted the release/0.4 branch March 2, 2022 19:39
@clehner
Copy link
Contributor Author

clehner commented Mar 2, 2022

Published:
rust-lang/crates.io-index@719d762
https://crates.io/crates/ssi/0.4.0
https://github.com/spruceid/ssi/releases/tag/v0.4.0

This was referenced Mar 2, 2022
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbihel sbihel sbihel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clehner @sbihel