Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default ssi/ring in DID method crates #402

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Conversation

clehner
Copy link
Contributor

@clehner clehner commented Mar 2, 2022

This updates DID method crates to follow the pattern of did:tz and did:webkey which use ssi/ring as a default feature, so that a build works by default.

e.g. these should all succeed:

cargo test -p did-ion
cargo test -p did-method-key
cargo test -p did-onion
cargo test -p did-pkh
cargo test -p did-tz
cargo test -p did-web
cargo test -p did-webkey

This should fix #169, #310, and #396.

DIDKit will need to be updated to set default-features=false for these crates - except for did-tz and did-webkey which already have this set.

A dev-dependency on did-method-key triggered default features on did-method-key; that dev-dependency but does not seem to be used anywhere, so is removed.

@clehner clehner marked this pull request as draft March 2, 2022 18:08
@clehner clehner mentioned this pull request Mar 2, 2022
@clehner clehner force-pushed the fix/crate-defaults branch from 4a6fcd8 to 41530d6 Compare March 2, 2022 18:21
@clehner clehner force-pushed the fix/crate-defaults branch from 41530d6 to c57b252 Compare March 2, 2022 20:59
@clehner clehner marked this pull request as ready for review March 2, 2022 21:58
@clehner clehner mentioned this pull request Mar 2, 2022
@clehner clehner requested a review from sbihel March 3, 2022 14:01
@clehner clehner merged commit c57b252 into main Mar 3, 2022
@clehner clehner deleted the fix/crate-defaults branch March 3, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs build error in DID Method crates
2 participants