Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local copy of latest stm32-rs required to build #5

Closed
richardeoin opened this issue Jun 13, 2019 · 4 comments · Fixed by #31
Closed

Local copy of latest stm32-rs required to build #5

richardeoin opened this issue Jun 13, 2019 · 4 comments · Fixed by #31
Assignees

Comments

@richardeoin
Copy link
Member

Waiting on an upstream release.

@richardeoin richardeoin changed the title Set stm32h7 version on the next stm32-rs release Local copy of latest stm32-rs required to build Jun 13, 2019
@richardeoin richardeoin self-assigned this Jun 13, 2019
@jordens
Copy link
Member

jordens commented Jul 3, 2019

@richardeoin @astraw @hargoniX do you have pending breaking changes for stm32-rs that you would like to land before 0.8 or can we try pushing for that release to get this out of the way? I don't have anything pending for 0.8.

@hargoniX
Copy link
Member

hargoniX commented Jul 3, 2019

I don't have done anything related to stm32-rs yet so that's a clear no from me

@astraw
Copy link
Member

astraw commented Jul 3, 2019

Also nothing pending from me.

@richardeoin
Copy link
Member Author

@jordens I've got two PRs open

stm32-rs/stm32-rs#241
stm32-rs/stm32-rs#246

Would be good to land them for 0.8

jordens added a commit that referenced this issue Jul 3, 2019
None of this will succeed until #5 is resolved.

Stable builds will only succeed once #6 is resolved.
jordens added a commit that referenced this issue Jul 3, 2019
This matches the currently targeted dependencies/rust versions.
It should be removed once #5 and #6 are resolved.
@richardeoin richardeoin added this to the v0.2.0 release milestone Jul 25, 2019
bors bot added a commit that referenced this issue Jul 29, 2019
19: timers, bugfix: fix periodic CountDown timer r=richardeoin a=richardeoin

Previously the `CountDown` timer failed to start a new countdown if the periodic timer was running and no `wait()` call was made in the previous period. This was as the UIF bit was already set.

See embedded-hal docs for the contract:
https://docs.rs/embedded-hal/0.2.3/embedded_hal/timer/trait.CountDown.html#tymethod.start

Add  example to demonstrate correct behaviour.

26: rcc: add options to configure more PLL outputs r=richardeoin a=richardeoin

* All 3 outputs of PLL1 can be configured.
* Moving closer to a generic interface for PLL2/PLL3; just needs macro
  definitions and call to setup.
* An `assert` will occour if pll1_p_ck is set independently when it is
  requried for sys_ck.
* When `pll1_r_ck` is `None` in the configuration struct, it is set if
  required to keep `traceclk` running. Afaict there's no documentation
  on acceptable frequencies for `traceclk`, set p_ck/2 as a sensible
  choice (can be overridden by setting some `pll1_r_ck`).

27: Init traits prelude r=richardeoin a=richardeoin

adc: Add initialisation trait

Simplifies usage:

```rust
let _ = adc::Adc::adc3(dp.ADC3, &mut delay, &mut ccdr);
```
to
```rust
let _ = dp.ADC3.adc(&mut delay, &mut ccdr);
```

Previous method still works.

Re-work arguments for timer, doesn't break anything as there aren't any examples yet.

Closes #20 

28: Porting i2c to the extension trait pattern r=richardeoin a=hargoniX

See #27 

31: dependencies: use stm32h7 PAC 0.8 r=richardeoin a=jordens

* remove and warnings notes on using the local build of stm32h7
* bump cortex-m-rt to 0.6.10 (.ARM.exidx section)
* mention that this works with beta

close: #5 

Co-authored-by: Richard Meadows <[email protected]>
Co-authored-by: Henrik Böving <[email protected]>
Co-authored-by: Robert Jördens <[email protected]>
bors bot added a commit that referenced this issue Jul 29, 2019
27: Init traits prelude r=richardeoin a=richardeoin

adc: Add initialisation trait

Simplifies usage:

```rust
let _ = adc::Adc::adc3(dp.ADC3, &mut delay, &mut ccdr);
```
to
```rust
let _ = dp.ADC3.adc(&mut delay, &mut ccdr);
```

Previous method still works.

Re-work arguments for timer, doesn't break anything as there aren't any examples yet.

Closes #20 

28: Porting i2c to the extension trait pattern r=richardeoin a=hargoniX

See #27 

31: dependencies: use stm32h7 PAC 0.8 r=richardeoin a=jordens

* remove and warnings notes on using the local build of stm32h7
* bump cortex-m-rt to 0.6.10 (.ARM.exidx section)
* mention that this works with beta

close: #5 

Co-authored-by: Richard Meadows <[email protected]>
Co-authored-by: Henrik Böving <[email protected]>
Co-authored-by: Robert Jördens <[email protected]>
@bors bors bot closed this as completed in #31 Jul 29, 2019
mtthw-meyer pushed a commit to mtthw-meyer/stm32h7xx-hal that referenced this issue Jul 9, 2020
None of this will succeed until stm32-rs#5 is resolved.

Stable builds will only succeed once stm32-rs#6 is resolved.
mtthw-meyer pushed a commit to mtthw-meyer/stm32h7xx-hal that referenced this issue Jul 9, 2020
This matches the currently targeted dependencies/rust versions.
It should be removed once stm32-rs#5 and stm32-rs#6 are resolved.
mtthw-meyer pushed a commit to mtthw-meyer/stm32h7xx-hal that referenced this issue Jul 9, 2020
27: Init traits prelude r=richardeoin a=richardeoin

adc: Add initialisation trait

Simplifies usage:

```rust
let _ = adc::Adc::adc3(dp.ADC3, &mut delay, &mut ccdr);
```
to
```rust
let _ = dp.ADC3.adc(&mut delay, &mut ccdr);
```

Previous method still works.

Re-work arguments for timer, doesn't break anything as there aren't any examples yet.

Closes stm32-rs#20 

28: Porting i2c to the extension trait pattern r=richardeoin a=hargoniX

See stm32-rs#27 

31: dependencies: use stm32h7 PAC 0.8 r=richardeoin a=jordens

* remove and warnings notes on using the local build of stm32h7
* bump cortex-m-rt to 0.6.10 (.ARM.exidx section)
* mention that this works with beta

close: stm32-rs#5 

Co-authored-by: Richard Meadows <[email protected]>
Co-authored-by: Henrik Böving <[email protected]>
Co-authored-by: Robert Jördens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants