rcc: add options to configure more PLL outputs #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* All 3 outputs of PLL1 can be configured. * Moving closer to a generic interface for PLL2/PLL3; just needs macro definitions and call to setup. * An `assert` will occour if pll1_p_ck is set independently when it is requried for sys_ck. * When `pll1_r_ck` is `None` in the configuration struct, it is set if required to keep `traceclk` running. Afaict there's no documentation on acceptable frequencies for `traceclk`, set p_ck/2 as a sensible choice (can be overridden by setting some `pll1_r_ck`).
|
bors try |
|
Anyhow, it's okay since #25 was merged. Ready for review. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 29, 2019
19: timers, bugfix: fix periodic CountDown timer r=richardeoin a=richardeoin Previously the `CountDown` timer failed to start a new countdown if the periodic timer was running and no `wait()` call was made in the previous period. This was as the UIF bit was already set. See embedded-hal docs for the contract: https://docs.rs/embedded-hal/0.2.3/embedded_hal/timer/trait.CountDown.html#tymethod.start Add example to demonstrate correct behaviour. 26: rcc: add options to configure more PLL outputs r=richardeoin a=richardeoin * All 3 outputs of PLL1 can be configured. * Moving closer to a generic interface for PLL2/PLL3; just needs macro definitions and call to setup. * An `assert` will occour if pll1_p_ck is set independently when it is requried for sys_ck. * When `pll1_r_ck` is `None` in the configuration struct, it is set if required to keep `traceclk` running. Afaict there's no documentation on acceptable frequencies for `traceclk`, set p_ck/2 as a sensible choice (can be overridden by setting some `pll1_r_ck`). 27: Init traits prelude r=richardeoin a=richardeoin adc: Add initialisation trait Simplifies usage: ```rust let _ = adc::Adc::adc3(dp.ADC3, &mut delay, &mut ccdr); ``` to ```rust let _ = dp.ADC3.adc(&mut delay, &mut ccdr); ``` Previous method still works. Re-work arguments for timer, doesn't break anything as there aren't any examples yet. Closes #20 28: Porting i2c to the extension trait pattern r=richardeoin a=hargoniX See #27 31: dependencies: use stm32h7 PAC 0.8 r=richardeoin a=jordens * remove and warnings notes on using the local build of stm32h7 * bump cortex-m-rt to 0.6.10 (.ARM.exidx section) * mention that this works with beta close: #5 Co-authored-by: Richard Meadows <[email protected]> Co-authored-by: Henrik Böving <[email protected]> Co-authored-by: Robert Jördens <[email protected]>
Timed out (retrying...) |
bors bot
added a commit
that referenced
this pull request
Jul 29, 2019
19: timers, bugfix: fix periodic CountDown timer r=richardeoin a=richardeoin Previously the `CountDown` timer failed to start a new countdown if the periodic timer was running and no `wait()` call was made in the previous period. This was as the UIF bit was already set. See embedded-hal docs for the contract: https://docs.rs/embedded-hal/0.2.3/embedded_hal/timer/trait.CountDown.html#tymethod.start Add example to demonstrate correct behaviour. 26: rcc: add options to configure more PLL outputs r=richardeoin a=richardeoin * All 3 outputs of PLL1 can be configured. * Moving closer to a generic interface for PLL2/PLL3; just needs macro definitions and call to setup. * An `assert` will occour if pll1_p_ck is set independently when it is requried for sys_ck. * When `pll1_r_ck` is `None` in the configuration struct, it is set if required to keep `traceclk` running. Afaict there's no documentation on acceptable frequencies for `traceclk`, set p_ck/2 as a sensible choice (can be overridden by setting some `pll1_r_ck`). Co-authored-by: Richard Meadows <[email protected]>
Timed out (retrying...) |
bors bot
added a commit
that referenced
this pull request
Jul 29, 2019
26: rcc: add options to configure more PLL outputs r=richardeoin a=richardeoin * All 3 outputs of PLL1 can be configured. * Moving closer to a generic interface for PLL2/PLL3; just needs macro definitions and call to setup. * An `assert` will occour if pll1_p_ck is set independently when it is requried for sys_ck. * When `pll1_r_ck` is `None` in the configuration struct, it is set if required to keep `traceclk` running. Afaict there's no documentation on acceptable frequencies for `traceclk`, set p_ck/2 as a sensible choice (can be overridden by setting some `pll1_r_ck`). Co-authored-by: Richard Meadows <[email protected]>
Build succeeded
|
tryMerge conflict |
mtthw-meyer
pushed a commit
to mtthw-meyer/stm32h7xx-hal
that referenced
this pull request
Jul 9, 2020
26: rcc: add options to configure more PLL outputs r=richardeoin a=richardeoin * All 3 outputs of PLL1 can be configured. * Moving closer to a generic interface for PLL2/PLL3; just needs macro definitions and call to setup. * An `assert` will occour if pll1_p_ck is set independently when it is requried for sys_ck. * When `pll1_r_ck` is `None` in the configuration struct, it is set if required to keep `traceclk` running. Afaict there's no documentation on acceptable frequencies for `traceclk`, set p_ck/2 as a sensible choice (can be overridden by setting some `pll1_r_ck`). Co-authored-by: Richard Meadows <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
definitions and call to setup.
assertwill occour if pll1_p_ck is set independently when it isrequried for sys_ck.
pll1_r_ckisNonein the configuration struct, it is set ifrequired to keep
traceclkrunning. Afaict there's no documentationon acceptable frequencies for
traceclk, set p_ck/2 as a sensiblechoice (can be overridden by setting some
pll1_r_ck).