Added route-behavior to article-page #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachterjohannes
force-pushed
the
feature/multi-page-route
branch
12 times, most recently
from
6c4ff22 to
2055f03
Compare
| ->addDefaultsIfNotSet() | ||
| ->children() | ||
| ->scalarNode('route_schema') | ||
| ->defaultValue('/{translator.trans("page")}-{object.getPageNumber()}') |
There was a problem hiding this comment.
would prefer to configure this also in the sulu_route
wachterjohannes
force-pushed
the
feature/multi-page-route
branch
from
2055f03 to
38695ec
Compare
alexander-schranz
requested changes
Apr 5, 2017
| ArticlePageDocument::class => [ | ||
| 'generator' => 'article_page', | ||
| 'options' => [ | ||
| 'route_schema' => '/{translator.trans("page")}-{object.getPageNumber()}', |
There was a problem hiding this comment.
would call the parameter just schema as we are in the route definition
There was a problem hiding this comment.
there it is also route_schema
alexander-schranz
approved these changes
Apr 5, 2017
wachterjohannes
added a commit
to wachterjohannes/SuluArticleBundle
that referenced
this pull request
Apr 5, 2017
wachterjohannes
added a commit
that referenced
this pull request
Apr 14, 2017
wachterjohannes
added a commit
to wachterjohannes/SuluArticleBundle
that referenced
this pull request
Apr 20, 2017
wachterjohannes
added a commit
to wachterjohannes/SuluArticleBundle
that referenced
this pull request
Apr 21, 2017
wachterjohannes
added a commit
to wachterjohannes/SuluArticleBundle
that referenced
this pull request
Apr 24, 2017
wachterjohannes
added a commit
to wachterjohannes/SuluArticleBundle
that referenced
this pull request
Apr 25, 2017
wachterjohannes
added a commit
to wachterjohannes/SuluArticleBundle
that referenced
this pull request
Apr 25, 2017
alexander-schranz
pushed a commit
that referenced
this pull request
Apr 25, 2017
* Implemented page document and API (#114) * implemented basic page document * added index pages to article * fixed serialization context of article and article-page (#118) * Add interface to manage article-pages (#116) * introduced css grunt job * added article-router * added page dropdown * added logic to create and update pages * renamed adapter * Added article title to page form (#123) * added article title * fixed selector for css stye * fixed jquery selector of grid-row * added page to content-navigation (#125) * Fixed create article from ghost (#126) * fixed create article from ghost * hide new page link for new articls * fixed code style * added delete page button (#132) * added translations (#128) * added route-behavior to article-page (#131) * Fixed priorities of subscriber (#137) * fixed priorities of subscriber * added tag to find routePath property * Fixed title property (article-title) and add page title property (#141) * fixed title property (article-title) and add page title property * added node-name-slugifier * Changed generating route only on publish (#138) * use publish event to generate routes * refactored because of sulu changes * Added page-number argument to website-article-controller (#142) * added serialization of pages * added pages data to article-document * fixed comments * Added synchronize children between draft and live (#139) * added synchronice children between draft and live * fixed preview for new pages * fixed serialization for preview * fixed testcases * Fixed versioning and remove-draft of article-pages (#145) * fixed versioning of article-pages * added upgrade note * added constraint for jackalope/jackalope * implemented duplicate article (#146) * Fixed preview-serialization of article pages (#154) * fixed preview-serialization of article pages * change view of renderArticle * fixed type change on list (#156) * Fixed metadata for article to sync remove (#155) * fixed metadata for article * fixed routable-subscriber to remove all routes (locales) * removed article-page copy locale (#157) * fixed code-style * fixed test-setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR adds the route to article-page.
TODO