Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added synchronize children between draft and live #139

Conversation

wachterjohannes
Copy link
Member

@wachterjohannes wachterjohannes commented Apr 10, 2017

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets none
Related issues/PRs build ontop #138 requires sulu/sulu-document-manager#109 and sulu/sulu#3302
License MIT
Documentation PR none

What's in this PR?

This PR add the synchronization of removed child nodes to the ArticleSubscriber.

Also this PR fixes the preview for new pages by hiding it (:

Why?

This is necessary because sulu until now delegates all the remove events to both workspaces.

To Do

  • Bring changes into core
  • Test adoptions

@wachterjohannes wachterjohannes changed the title Added synchronice children between draft and live [WIP] Added synchronice children between draft and live Apr 10, 2017
@wachterjohannes wachterjohannes changed the title [WIP] Added synchronice children between draft and live [WIP] Added synchronize children between draft and live Apr 10, 2017
@wachterjohannes wachterjohannes force-pushed the feature/multi-page-remove-page branch 4 times, most recently from 307e46a to 5ff1945 Compare April 13, 2017 13:28
@wachterjohannes wachterjohannes force-pushed the feature/multi-page branch 2 times, most recently from 3a3a15b to 852a7ea Compare April 14, 2017 05:35
@wachterjohannes wachterjohannes force-pushed the feature/multi-page-remove-page branch 2 times, most recently from db8c455 to 6335543 Compare April 14, 2017 07:08
@wachterjohannes wachterjohannes force-pushed the feature/multi-page-remove-page branch from 6335543 to ebca270 Compare April 14, 2017 07:40
@wachterjohannes wachterjohannes changed the title [WIP] Added synchronize children between draft and live Added synchronize children between draft and live Apr 14, 2017
@alexander-schranz alexander-schranz merged commit dad5abc into sulu:feature/multi-page Apr 18, 2017
@wachterjohannes wachterjohannes deleted the feature/multi-page-remove-page branch April 18, 2017 08:10
wachterjohannes added a commit to wachterjohannes/SuluArticleBundle that referenced this pull request Apr 20, 2017
* added synchronice children between draft and live

* fixed preview for new pages
wachterjohannes added a commit to wachterjohannes/SuluArticleBundle that referenced this pull request Apr 21, 2017
* added synchronice children between draft and live

* fixed preview for new pages
wachterjohannes added a commit to wachterjohannes/SuluArticleBundle that referenced this pull request Apr 24, 2017
* added synchronice children between draft and live

* fixed preview for new pages
wachterjohannes added a commit to wachterjohannes/SuluArticleBundle that referenced this pull request Apr 25, 2017
* added synchronice children between draft and live

* fixed preview for new pages
wachterjohannes added a commit to wachterjohannes/SuluArticleBundle that referenced this pull request Apr 25, 2017
* added synchronice children between draft and live

* fixed preview for new pages
alexander-schranz pushed a commit that referenced this pull request Apr 25, 2017
* Implemented page document and API (#114)

* implemented basic page document

* added index pages to article

* fixed serialization context of article and article-page (#118)

* Add interface to manage article-pages (#116)

* introduced css grunt job

* added article-router

* added page dropdown

* added logic to create and update pages

* renamed adapter

* Added article title to page form (#123)

* added article title

* fixed selector for css stye

* fixed jquery selector of grid-row

* added page to content-navigation (#125)

* Fixed create article from ghost (#126)

* fixed create article from ghost

* hide new page link for new articls

* fixed code style

* added delete page button (#132)

* added translations (#128)

* added route-behavior to article-page (#131)

* Fixed priorities of subscriber (#137)

* fixed priorities of subscriber

* added tag to find routePath property

* Fixed title property (article-title) and add page title property (#141)

* fixed title property (article-title) and add page title property

* added node-name-slugifier

* Changed generating route only on publish (#138)

* use publish event to generate routes

* refactored because of sulu changes

* Added page-number argument to website-article-controller (#142)

* added serialization of pages

* added pages data to article-document

* fixed comments

* Added synchronize children between draft and live (#139)

* added synchronice children between draft and live

* fixed preview for new pages

* fixed serialization for preview

* fixed testcases

* Fixed versioning and remove-draft of article-pages (#145)

* fixed versioning of article-pages

* added upgrade note

* added constraint for jackalope/jackalope

* implemented duplicate article (#146)

* Fixed preview-serialization of article pages (#154)

* fixed preview-serialization of article pages

* change view of renderArticle

* fixed type change on list (#156)

* Fixed metadata for article to sync remove (#155)

* fixed metadata for article

* fixed routable-subscriber to remove all routes (locales)

* removed article-page copy locale (#157)

* fixed code-style

* fixed test-setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants