Fix flaky test by sorting slices

[dibyom]

Changes

TestGetVarSubstitutionExpressionsForPipelineResult was flaky since the expected
test output was in a fixed order while the function under test was iterating
through a map where order is not guaranteed. This commit fixes it by sorting
the inputs to cmp.Diff

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs included if any changes are user facing
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[dibyom]

/kind flake

[dibyom]

/test check-pr-has-kind-label

[tekton-robot]

@dibyom: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test pull-tekton-pipeline-alpha-integration-tests
• /test pull-tekton-pipeline-build-tests
• /test pull-tekton-pipeline-integration-tests
• /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

• /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lbernick]

you'll also have to change the v1 package unfortunately

FYI @Yongxuanzhang

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/apis/OWNERS [jerop,lbernick]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dibyom]

you'll also have to change the v1 package unfortunately

I don't see a resultref in the v1 package. Is that intentional?

(I also don't see a CRD struct in result ref - maybe we could just move it out of v1beta1?)

[lbernick]

/lgtm

I don't see a resultref in the v1 package. Is that intentional?

oops-- should have looked more carefully

(I also don't see a CRD struct in result ref - maybe we could just move it out of v1beta1?)

good idea!

[Yongxuanzhang]

oh thank you!