Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added request WCA id page, and cleaned up error messages when trying to log in #267

Merged
merged 8 commits into from
Dec 12, 2015

Conversation

jfly
Copy link
Contributor

@jfly jfly commented Dec 10, 2015

This is some long overdue polishing with our accounts system.

A lot of people think they already have WCA website accounts because they have a WCA id, or because they used the WCA website to register. Now when you try to log in with an unassigned WCA id, we give a helpful message (#235):

2015-12-10_1226x394_kaladin
2015-12-10_1210x543_kaladin
2015-12-10_1239x544_kaladin

If they follow those instructions and create an account, they will see a notification to request a WCA id:

2015-12-10_1222x367_kaladin

Clicking that notification will take you to the "request a WCA id" page:

2015-12-10_1257x836_kaladin

After they choose a WCA id, as per @Luis-J-Ianez's idea, we suggest some likely delegates, but we also give them a search box to pick any delegate:

2015-12-10_1223x569_kaladin

Note that we don't let them request a WCA id that has already been assigned to a non-dummy user:

2015-12-10_1241x860_kaladin

But you can request a WCA id that belongs to a dummy account:

2015-12-10_1235x867_kaladin

After selecting a WCA id and a delegate, the user will see a success! message:

2015-12-10_1221x377_kaladin

Both the delegate and the user will be emailed:

2015-12-10_1255x700_kaladin

And the delegate will see a notification every time they log in:

2015-12-10_1230x356_kaladin

The "approve a WCA id request" piece of of this is the least polished, but I think it works fine. First you click approve:

2015-12-10_1237x307_kaladin

Which just moves the WCA id from the unconfirmed textbox into the confirmed text box:

2015-12-10_1238x304_kaladin

The delegate still has to press save after this.

jfly added 5 commits December 10, 2015 11:33
This is a large part of thewca#260.  Still need to implement emailing the
delegate the user chose to do the connecting.
still need to click save after clicking approve. It just saves you from
having to copy paste. thewca#260.
"N errors prohibited this user from being saved". This fixes thewca#235.
@Luis-J-Ianez
Copy link

Looks awesome, Jeremy. Just one comment: to me it sounds weird the "Request WCA id" wording. I know that it's stupid me suggesting that there are issues in your English, :P but requesting something that you already have, is not weird? What about "Claim your WCA id"?

@jfly jfly merged commit 055a993 into thewca:master Dec 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants