Avoid generating invalid root route when there's no model #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,7 +63,8 @@ def unnamed_constants | |||
| end | |||
|
|
|||
| def dashboard_routes | |||
| ERB.new(File.read(routes_file_path)).result(binding) | |||
| erb = ERB.new(File.read(routes_file_path), nil, '-') | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
This fixes #502, and fixes #516. When there's no model, `rails generate administrate:install` invokes `administrate:routes` generator first, and it generates the following invalid routing: ```ruby Rails.application.routes.draw do namespace :admin do root to: "#index" end ... ``` ... and that causes the error in `administrate:dashboard` generator.
nickcharlton
added a commit
that referenced
this pull request
Dec 16, 2016
nickcharlton
added a commit
that referenced
this pull request
Dec 17, 2016
nickcharlton
added a commit
that referenced
this pull request
Dec 19, 2016
|
Closing as this should be fixed with #713. Please open an issue if that's not the case! |
fwolfst
pushed a commit
to fwolfst/administrate
that referenced
this pull request
Mar 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #502, and fixes #516.
When there's no model,
rails generate administrate:installinvokesadministrate:routesgenerator first, and it generates the following invalid routing:... and that causes the error in
administrate:dashboardgenerator.