Avoid writing to routes.rb when no models exist. #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickcharlton
force-pushed
the
nc-avoid-writing-empty-admin-routes
branch
from
c6f156b to
17991ab
Compare
mike-burns
reviewed
Dec 19, 2016
| @@ -8,7 +8,7 @@ class RoutesGenerator < Rails::Generators::Base | |||
| source_root File.expand_path("../templates", __FILE__) | |||
|
|
|||
| def insert_dashboard_routes | |||
| unless File.read(rails_routes_file_path).include?(dashboard_routes) | |||
| unless routes_includes_resources? || valid_dashboard_models.empty? | |||
There was a problem hiding this comment.
Do you mind moving these conditions into a should_route_dashboard? method? I struggle to read unless, especially with a longer logical expression.
There was a problem hiding this comment.
Yes, I like this idea! Done in a fixup if you'd take a look!
|
LGTM. |
nickcharlton
force-pushed
the
nc-avoid-writing-empty-admin-routes
branch
from
1072289 to
db33c4c
Compare
This was referenced Dec 19, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes: #502, #516, #555, #649, #583, #601, #613.