-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle running install generator where no admin resources defined #583
Closed
lukeredpath
wants to merge
2
commits into
thoughtbot:master
from
lukeredpath:bug/handle-no-admin-resources
Closed
Handle running install generator where no admin resources defined #583
lukeredpath
wants to merge
2
commits into
thoughtbot:master
from
lukeredpath:bug/handle-no-admin-resources
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it 'skips abstract models without a warning' do | ||
stub_generator_dependencies | ||
routes = file("config/routes.rb") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing whitespace detected.
lukeredpath
force-pushed
the
bug/handle-no-admin-resources
branch
from
May 16, 2016 12:07
7815e8d
to
7e49a0b
Compare
This is great 👍 @lukeredpath |
Possible dupe of #516 though I just realised. |
nickcharlton
added a commit
that referenced
this pull request
Dec 16, 2016
nickcharlton
added a commit
that referenced
this pull request
Dec 17, 2016
nickcharlton
added a commit
that referenced
this pull request
Dec 19, 2016
Closing as this should be fixed with #713. Please open an issue if that's not the case! |
fwolfst
pushed a commit
to fwolfst/administrate
that referenced
this pull request
Mar 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve the issue I was seeing in #581