Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: overlay type definitions and operations #648

Merged
merged 1 commit into from
Jan 14, 2025
Merged

feat: overlay type definitions and operations #648

merged 1 commit into from
Jan 14, 2025

Conversation

rphmeier
Copy link
Contributor

This defines the Overlay types. I tried to make it passably fast at an algorithmic level and will follow up with integrations!

@rphmeier Graphite App
Copy link
Contributor Author

rphmeier commented Dec 20, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rphmeier rphmeier mentioned this pull request Dec 20, 2024
Merged
@rphmeier rphmeier force-pushed the rh-overlay-definition-and-ops branch from 15a022c to 3479f60 Compare December 23, 2024 17:53
@rphmeier rphmeier mentioned this pull request Dec 23, 2024
Closed
@rphmeier rphmeier force-pushed the rh-overlay-definition-and-ops branch from 3479f60 to 735bb7f Compare December 31, 2024 18:39
@rphmeier rphmeier changed the base branch from master to rh-bitbox-nocopy December 31, 2024 18:39
This was referenced Dec 31, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
gabriele-0201
gabriele-0201 approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@gabriele-0201 gabriele-0201 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo some doubts on comments this seems to be a great starting point to manage Overlays. I like the imbl and Map + Vector approach to handle a quick creation and indexing of the overlays!

nomt/src/overlay.rs Outdated Show resolved Hide resolved
nomt/src/overlay.rs Outdated Show resolved Hide resolved
nomt/src/overlay.rs Outdated Show resolved Hide resolved
nomt/src/overlay.rs Outdated Show resolved Hide resolved
nomt/src/overlay.rs Show resolved Hide resolved
@pepyakin pepyakin changed the base branch from rh-bitbox-nocopy to graphite-base/648 January 2, 2025 12:33
@pepyakin pepyakin force-pushed the rh-overlay-definition-and-ops branch from 735bb7f to 57178b0 Compare January 2, 2025 12:35
@pepyakin pepyakin changed the base branch from graphite-base/648 to master January 2, 2025 12:36
@pepyakin pepyakin force-pushed the rh-overlay-definition-and-ops branch from 57178b0 to 56e5220 Compare January 2, 2025 12:36
@rphmeier rphmeier force-pushed the rh-overlay-definition-and-ops branch from 56e5220 to eefc27e Compare January 13, 2025 19:45
@rphmeier rphmeier mentioned this pull request Jan 13, 2025
Merged
@rphmeier Graphite App
Copy link
Contributor Author

rphmeier commented Jan 14, 2025 •
edited
Loading

Merge activity

  • Jan 14, 2:29 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 14, 2:29 PM EST: A user merged this pull request with Graphite.

@rphmeier rphmeier merged commit fd212a6 into master Jan 14, 2025
8 checks passed
@rphmeier rphmeier deleted the rh-overlay-definition-and-ops branch January 14, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriele-0201 gabriele-0201 gabriele-0201 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rphmeier @gabriele-0201