refactor: separate update_inner from commit_inner #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rphmeier
force-pushed
the
rh-overlay-nomt-api
branch
from
75ffedd to
beec0e9
Compare
rphmeier
force-pushed
the
rh-split-update-inner-out
branch
from
adbfc21 to
234efb0
Compare
pepyakin
force-pushed
the
rh-overlay-nomt-api
branch
from
beec0e9 to
bb122ed
Compare
pepyakin
force-pushed
the
rh-split-update-inner-out
branch
from
234efb0 to
08341e5
Compare
gabriele-0201
approved these changes
Jan 4, 2025
deuszx
reviewed
Jan 6, 2025
Comment on lines
+430
to
+434
| // Effectively commit the transaction. | ||
| // If 'witness' is set to true, it collects the witness and | ||
| // returns `(Node, Some(Witness), Some(WitnessedOperations))` | ||
| // Otherwise, it solely returns the new root node, returning | ||
| // `(Node, None, None)` |
There was a problem hiding this comment.
Looks like this comment was meant to be put on update_inner and not commit_inner?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.