-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opt: defer drop of old pages in page cache til end #656
base: master
Are you sure you want to change the base?
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3a9c06f
to
8b0ef5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside gt restack
being needed, 97f5eff looks good!
Just to be sure I got it right, before cache_entry.page_data = updated_page.page.freeze().inner;
was dropping in place the FatPage
leading to some computation that is better to be deferred to the end of the critical path (technically during the wal writing, before the beginning of the ht writing).
8b0ef5c
to
3c6c0c7
Compare
97f5eff
to
3553de3
Compare
3553de3
to
97e1041
Compare
No description provided.