Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: defer drop of old pages in page cache til end #656

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rphmeier
Copy link
Contributor

No description provided.

Copy link
Contributor

@gabriele-0201 gabriele-0201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside gt restack being needed, 97f5eff looks good!

Just to be sure I got it right, before cache_entry.page_data = updated_page.page.freeze().inner; was dropping in place the FatPage leading to some computation that is better to be deferred to the end of the critical path (technically during the wal writing, before the beginning of the ht writing).

@pepyakin pepyakin changed the base branch from rh-bitbox-nocopy to graphite-base/656 January 2, 2025 12:33
@pepyakin pepyakin force-pushed the rh-defer-drop-arc-pages branch from 97f5eff to 3553de3 Compare January 2, 2025 12:37
@pepyakin pepyakin changed the base branch from graphite-base/656 to master January 2, 2025 12:38
@pepyakin pepyakin force-pushed the rh-defer-drop-arc-pages branch from 3553de3 to 97e1041 Compare January 2, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants