opt: do not copy pages before bitbox writeout #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 30, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 30, 2024
rphmeier
force-pushed
the
rh-write-arc
branch
from
2fb1139 to
a65b52c
Compare
rphmeier
force-pushed
the
rh-bitbox-nocopy
branch
from
3a9c06f to
8b0ef5c
Compare
This was referenced Dec 31, 2024
gabriele-0201
approved these changes
Jan 2, 2025
pepyakin
approved these changes
Jan 2, 2025
pepyakin
force-pushed
the
rh-bitbox-nocopy
branch
from
8b0ef5c to
d82e0e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new
WriteArcI/O command to avoid a page copy when writing to bitbox. This is currently a major bottleneck duringsync, since these page copies are single-threaded and we now copy pages during merkle commit (needed for overlays).