Add local-hostname to metadata #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #66 +/- ##
=======================================
Coverage 33.57% 33.57%
=======================================
Files 3 3
Lines 420 420
=======================================
Hits 141 141
Misses 256 256
Partials 23 23
Continue to review full report at Codecov.
|
jacobweinstock
added
kind/feature
displague
approved these changes
Sep 16, 2021
mmlb
approved these changes
Sep 21, 2021
jacobweinstock
added a commit
to jacobweinstock/hegel
that referenced
this pull request
May 5, 2022
Hello. I would like to request the Approver role in the Hegel repo. GitHub Username @jacobweinstock Role Approver Requirements: - approver from 2020-10-01 until 2022-04-01 - reviewer from 2022-04-29 until present Reviews: - tinkerbell#87 - tinkerbell#66 - tinkerbell#65 - tinkerbell#60 Maintainers @chrisdoherty4, @nshalman, @mmlb
3 tasks
mergify bot
added a commit
that referenced
this pull request
May 5, 2022
Hello. I would like to request the Approver role in the Hegel repo. GitHub Username @jacobweinstock Role Approver Requirements: - approver from 2020-10-01 until 2022-04-01 - reviewer from 2022-04-29 until present Reviews: - #87 - #66 - #65 - #60 Maintainers @chrisdoherty4, @nshalman, @mmlb ## Description ## Why is this needed Fixes: # ## How Has This Been Tested? ## How are existing users impacted? What migration steps/scripts do we need? ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds local-hostname to the ec2 style metadata output to allow for better consumption of metadata by cloud-init
Why is this needed
When cloud-init attempts to set the hostname using the ec2 metadata source, it uses the value of local-hostname.
How Has This Been Tested?
Ran existing test suite
How are existing users impacted? What migration steps/scripts do we need?
This should not affect existing users, other than those that are hitting issues with cloud-init not setting the hostname when using hegel as an ec2 metadata source.