Request for Approvers Role #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello. I would like to request the Approver role in the Hegel repo. GitHub Username @jacobweinstock Role Approver Requirements: - approver from 2020-10-01 until 2022-04-01 - reviewer from 2022-04-29 until present Reviews: - tinkerbell#87 - tinkerbell#66 - tinkerbell#65 - tinkerbell#60 Maintainers @chrisdoherty4, @nshalman, @mmlb
jacobweinstock
requested review from
chrisdoherty4,
mmlb and
nshalman
as code owners
Codecov Report
@@ Coverage Diff @@
## main #97 +/- ##
=======================================
Coverage 51.87% 51.87%
=======================================
Files 3 3
Lines 401 401
=======================================
Hits 208 208
Misses 164 164
Partials 29 29 Continue to review full report at Codecov.
|
chrisdoherty4
approved these changes
May 5, 2022
mmlb
approved these changes
May 5, 2022
nshalman
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I would like to request the Approver role in the Hegel repo.
GitHub Username
@jacobweinstock
Role
Approver
Requirements:
Reviews:
Maintainers
@chrisdoherty4, @nshalman, @mmlb
Description
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: