Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

update gh-actions to use node 16 #5637

Merged
merged 2 commits into from
Oct 24, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,10 @@ jobs:
yarncheck:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
- run: npm install -g yarn
- run: yarn install --ignore-scripts --ignore-engines
- run: test -z "$(git diff)" || (echo 'Please run yarn and commit all changes to yarn.lock'; false)
Expand All @@ -44,9 +46,9 @@ jobs:
runs-on: ${{ matrix.platform }}

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand Down
4 changes: 3 additions & 1 deletion packages/core/test/lib/commands/compile.js
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,9 @@ describe("compile", function () {
});

it("prints a list of docker tags", async function () {
this.timeout(20000);
this.timeout(
60000 * 2 // oh boy!
);
Comment on lines +103 to +105
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minutes is an egregious limit for a test. OTOH, these tests shouldn't hit the network. I opened #5639 to capture that.

const options = {
list: "docker"
};
Expand Down